From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3F95B8C9E8 for ; Fri, 4 Nov 2022 08:43:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20E21376D7 for ; Fri, 4 Nov 2022 08:43:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Nov 2022 08:42:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3F69143EC8 for ; Fri, 4 Nov 2022 08:42:59 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 4 Nov 2022 08:42:55 +0100 Message-Id: <20221104074255.8172-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH manager] ui: {guest, node} summary: use correct unit for CPU usage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 07:43:31 -0000 One could also think about showing something like '% of N CPUs', but this can be inaccurate for older data, because the number of CPUs can change. Reported in the community forum: https://forum.proxmox.com/threads/117362/ Signed-off-by: Fiona Ebner --- www/manager6/node/Summary.js | 1 + www/manager6/panel/GuestSummary.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js index 8680fa5f..320f2247 100644 --- a/www/manager6/node/Summary.js +++ b/www/manager6/node/Summary.js @@ -162,6 +162,7 @@ Ext.define('PVE.node.Summary', { title: gettext('CPU usage'), fields: ['cpu', 'iowait'], fieldTitles: [gettext('CPU usage'), gettext('IO delay')], + unit: 'percent', store: rrdstore, }, { diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js index 6532c3e9..1565db3f 100644 --- a/www/manager6/panel/GuestSummary.js +++ b/www/manager6/panel/GuestSummary.js @@ -75,6 +75,7 @@ Ext.define('PVE.guest.Summary', { pveSelNode: me.pveSelNode, fields: ['cpu'], fieldTitles: [gettext('CPU usage')], + unit: 'percent', store: rrdstore, }, { -- 2.30.2