From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4D0CB8A557 for ; Thu, 20 Oct 2022 12:05:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FA505F4E for ; Thu, 20 Oct 2022 12:05:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Oct 2022 12:05:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6221C44ABE; Thu, 20 Oct 2022 12:05:58 +0200 (CEST) Date: Thu, 20 Oct 2022 12:05:57 +0200 From: Wolfgang Bumiller To: Alexandre Derumier Cc: pve-devel@lists.proxmox.com Message-ID: <20221020100557.pncxpsemrinqwghf@casey.proxmox.com> References: <20221019222429.997436-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019222429.997436-1-aderumier@odiso.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.253 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-common] fix #4299: network : disable_ipv6: fix path checking X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 10:05:59 -0000 On Thu, Oct 20, 2022 at 12:24:29AM +0200, Alexandre Derumier wrote: > It's possible to have a > /proc/sys/net/ipv6/ directory > > but no > /proc/sys/net/ipv6/conf/$iface/disable_ipv6 Do we know why this happens? That doesn't seem right to me, unless some kind of race somewhere with the interface creation? Or is there a legitimate kernel option that causes this? > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm > index c468e40..9d726cd 100644 > --- a/src/PVE/Network.pm > +++ b/src/PVE/Network.pm > @@ -210,8 +210,8 @@ my $cond_create_bridge = sub { > > sub disable_ipv6 { > my ($iface) = @_; > - return if !-d '/proc/sys/net/ipv6'; # ipv6 might be completely disabled > my $file = "/proc/sys/net/ipv6/conf/$iface/disable_ipv6"; > + return if !-e $file; # ipv6 might be completely disabled > open(my $fh, '>', $file) or die "failed to open $file for writing: $!\n"; > print {$fh} "1\n" or die "failed to disable link-local ipv6 for $iface\n"; > close($fh); > -- > 2.30.2