From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5C9F18915B for ; Mon, 17 Oct 2022 15:58:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F4DF20121 for ; Mon, 17 Oct 2022 15:58:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 17 Oct 2022 15:58:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B295C44A4F for ; Mon, 17 Oct 2022 15:58:30 +0200 (CEST) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Mon, 17 Oct 2022 15:56:32 +0200 Message-Id: <20221017135632.569782-2-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221017135632.569782-1-d.tschlatscher@proxmox.com> References: <20221017135632.569782-1-d.tschlatscher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.168 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/2] gui: reorder with advanced section X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 13:58:32 -0000 The new MTU field and the rate limit field are now in the advanced section of the NetworkInputPanel to parallel the layout of the NetworkEdit for VMs. Signed-off-by: Daniel Tschlatscher --- While the layout now is the same as in the VM NetworkEdit, I just feel like the advanced column does not create such a nice UI flow here. Therefore, I included this as an optional patch, as it still has some merit, but may be dropped if deemed unnecessary. www/manager6/lxc/Network.js | 42 +++++++++++++++++++++---------------- 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js index d6a35a49..e9c32334 100644 --- a/www/manager6/lxc/Network.js +++ b/www/manager6/lxc/Network.js @@ -122,30 +122,12 @@ Ext.define('PVE.lxc.NetworkInputPanel', { name: 'tag', value: cdata.tag, }, - { - xtype: 'numberfield', - name: 'rate', - fieldLabel: gettext('Rate limit') + ' (MB/s)', - minValue: 0, - maxValue: 10*1024, - value: cdata.rate, - emptyText: 'unlimited', - allowBlank: true, - }, { xtype: 'proxmoxcheckbox', fieldLabel: gettext('Firewall'), name: 'firewall', value: cdata.firewall, }, - { - xtype: 'proxmoxintegerfield', - fieldLabel: gettext('MTU'), - name: 'mtu', - value: cdata.mtu, - minValue: 64, - maxValue: 65535, - }, ]; let dhcp4 = cdata.ip === 'dhcp'; @@ -290,6 +272,30 @@ Ext.define('PVE.lxc.NetworkInputPanel', { }, ]; + me.advancedColumn1 = [ + { + xtype: 'proxmoxintegerfield', + fieldLabel: gettext('MTU'), + name: 'mtu', + value: cdata.mtu, + minValue: 64, + maxValue: 65535, + }, + ]; + + me.advancedColumn2 = [ + { + xtype: 'numberfield', + name: 'rate', + fieldLabel: gettext('Rate limit') + ' (MB/s)', + minValue: 0, + maxValue: 10*1024, + value: cdata.rate, + emptyText: 'unlimited', + allowBlank: true, + }, + ]; + me.callParent(); }, }); -- 2.30.2