From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 50FA489713 for ; Mon, 17 Oct 2022 15:28:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30F041FDBC for ; Mon, 17 Oct 2022 15:28:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 17 Oct 2022 15:28:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BC56044A57 for ; Mon, 17 Oct 2022 15:28:41 +0200 (CEST) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Mon, 17 Oct 2022 15:24:00 +0200 Message-Id: <20221017132400.82359-1-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.236 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] fix #4284: add read-only to non-hotpluggable disk options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 13:28:43 -0000 Changing the read-only status of a disk is not possible through QMP, so it needs to be exempt from the hotpluggable values as to notify the user. Signed-off-by: Leo Nunner --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4e85dd0..08a172d 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5213,7 +5213,8 @@ sub vmconfig_update_disk { safe_string_ne($drive->{iothread}, $old_drive->{iothread}) || safe_string_ne($drive->{queues}, $old_drive->{queues}) || safe_string_ne($drive->{cache}, $old_drive->{cache}) || - safe_string_ne($drive->{ssd}, $old_drive->{ssd})) { + safe_string_ne($drive->{ssd}, $old_drive->{ssd}) || + safe_string_ne($drive->{ro}, $old_drive->{ro})) { die "skip\n"; } -- 2.30.2