From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AA083918C5 for ; Fri, 7 Oct 2022 14:43:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C7FA25FF4 for ; Fri, 7 Oct 2022 14:42:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Oct 2022 14:42:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7D21244813 for ; Fri, 7 Oct 2022 14:42:05 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 7 Oct 2022 14:41:53 +0200 Message-Id: <20221007124156.110246-17-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221007124156.110246-1-f.ebner@proxmox.com> References: <20221007124156.110246-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/5] ui: qemu/lxc: cpu edit: fix 'create' parameter for delete_if_default() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2022 12:43:05 -0000 For lxc, commit 3f40bc29 ("lxc/ResoureEdit: move some cpu fields to advanced options") made the fields available in the create wizard, so the comment is also wrong. Both wizards do a 'delete kv.delete' in their onSubmit() function, so it didn't actually matter in practice. Signed-off-by: Fiona Ebner --- www/manager6/lxc/ResourceEdit.js | 5 ++--- www/manager6/qemu/ProcessorEdit.js | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager6/lxc/ResourceEdit.js b/www/manager6/lxc/ResourceEdit.js index f926d784..7b0d6886 100644 --- a/www/manager6/lxc/ResourceEdit.js +++ b/www/manager6/lxc/ResourceEdit.js @@ -46,9 +46,8 @@ Ext.define('PVE.lxc.CPUInputPanel', { onGetValues: function(values) { var me = this; - // cpu{limit,unit} aren't in the wizard so create is always false - PVE.Utils.delete_if_default(values, 'cpulimit', '0', 0); - PVE.Utils.delete_if_default(values, 'cpuunits', '1024', 0); + PVE.Utils.delete_if_default(values, 'cpulimit', '0', me.insideWizard); + PVE.Utils.delete_if_default(values, 'cpuunits', '1024', me.insideWizard); return values; }, diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js index 1bed2877..7bb4cc60 100644 --- a/www/manager6/qemu/ProcessorEdit.js +++ b/www/manager6/qemu/ProcessorEdit.js @@ -27,8 +27,8 @@ Ext.define('PVE.qemu.ProcessorInputPanel', { values.delete = values.delete.join(','); } - PVE.Utils.delete_if_default(values, 'cpulimit', '0', 0); - PVE.Utils.delete_if_default(values, 'cpuunits', '1024', 0); + PVE.Utils.delete_if_default(values, 'cpulimit', '0', me.insideWizard); + PVE.Utils.delete_if_default(values, 'cpuunits', '1024', me.insideWizard); // build the cpu options: me.cpu.cputype = values.cputype; -- 2.30.2