From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E74391833 for ; Fri, 7 Oct 2022 14:42:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE25E25FD1 for ; Fri, 7 Oct 2022 14:42:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Oct 2022 14:42:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6484244864 for ; Fri, 7 Oct 2022 14:42:04 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 7 Oct 2022 14:41:37 +0200 Message-Id: <20221007124156.110246-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, qemu.pm, pvestatd.pm, lxc.pm, cluster.pm, cgroup.pm, guesthelpers.pm, config.pm] Subject: [pve-devel] [PATCH-SERIES docs/(guest-)common/qemu-server/container/manager] cpuunits improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2022 12:42:49 -0000 This series does multiple things, all related to cpuunits: * Updates the documentation in pve-docs and pve-container for the cgroup v2 cpuunits defaults and limits, while still mentioning the old values that apply to legacy cgroup v1 hosts. qemu-server is already updated. * Move the get_cpuunits() helper from qemu-server to guest-common and re-use it for containers. Makes behavior consistent with VMs and allows starting existing containers with an out-of-range value. This requires dependency bumps qemu-server,pve-container -> guest-common. * Drop an unused parameter for change_cpu_shares(). Here technically, a Breaks from common -> pve-container,qemu-server is needed, before we can introduce a new parameter. * Clamp cpuunits value already when setting via API. * Broadcast the node's cgroup version as a pmxcfs kv entry. This is the v2 of that patch, changes are noted there and use the value in the UI to dynamically show the correct defaults and limits. docs: Fiona Ebner (2): qm: resource limits: update systemd setting name for cpuunits pct/qm: update cpuunits default pct.adoc | 5 +++-- qm.adoc | 14 +++++++------- 2 files changed, 10 insertions(+), 9 deletions(-) guest-common Fiona Ebner (1): helpers: move get_cpuunits helper from qemu-server src/PVE/GuestHelpers.pm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) container: Fiona Ebner (7): config: cpuunits: drop description for outdated special value change cpu shares: hard-code cgroupv1 default parameter config: cpuunits: update default description use helper from guest-common for cpuunits config: replace mentions of "VM" with "container" change cpu shares: drop superfluous parameter api: create/update vm: clamp cpuunit value src/PVE/API2/LXC.pm | 3 +++ src/PVE/API2/LXC/Config.pm | 4 ++++ src/PVE/LXC.pm | 5 ++--- src/PVE/LXC/Config.pm | 19 +++++++++++-------- 4 files changed, 20 insertions(+), 11 deletions(-) qemu-server: Fiona Ebner (3): move get_cpuunits helper to guest-common change cpu shares: drop superfluous parameter api: create/update vm: clamp cpuunit value PVE/API2/Qemu.pm | 6 ++++++ PVE/QemuServer.pm | 23 ++++------------------- 2 files changed, 10 insertions(+), 19 deletions(-) common: Fiona Ebner (1): change cpu shares: drop unused $cgroupv1_default parameter src/PVE/CGroup.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) manager: Fiona Ebner (5): ui: lxc: cpu edit: drop superfluous delete_if_default ui: qemu/lxc: cpu edit: fix 'create' parameter for delete_if_default() ui: lxc/qemu: cpu edit: use emptyText for cpuunits cluster resources: add cgroup-mode to node properties ui: lxc/qemu: cpu edit: make cpuunits depend on node's cgroup version PVE/API2/Cluster.pm | 12 +++++++++ PVE/Service/pvestatd.pm | 16 ++++++++++++ www/manager6/lxc/CreateWizard.js | 8 ++++++ www/manager6/lxc/ResourceEdit.js | 39 +++++++++++++++++++++++------- www/manager6/lxc/Resources.js | 8 +++++- www/manager6/qemu/CreateWizard.js | 8 ++++++ www/manager6/qemu/HardwareView.js | 8 +++++- www/manager6/qemu/ProcessorEdit.js | 34 ++++++++++++++++++++------ 8 files changed, 114 insertions(+), 19 deletions(-) -- 2.30.2