From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0968391376 for ; Thu, 6 Oct 2022 14:45:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0E25F1C6D5 for ; Thu, 6 Oct 2022 14:44:59 +0200 (CEST) Received: from lana.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Thu, 6 Oct 2022 14:44:57 +0200 (CEST) Received: by lana.proxmox.com (Postfix, from userid 10043) id CAA962C232D; Thu, 6 Oct 2022 14:44:48 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 6 Oct 2022 14:44:46 +0200 Message-Id: <20221006124447.120701-8-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221006124447.120701-1-s.hanreich@proxmox.com> References: <20221006124447.120701-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.353 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qm.pm] Subject: [pve-devel] [PATCH v2 qemu-server 1/2] add migrate-hook and query-migrate-hook commands to CLI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2022 12:45:27 -0000 migrate-hook runs the migrate hook by forking a new process and attaching to its STDOUT. This helps us deal with long running hookscripts, that could otherwise block. Additionally it safeguards us from hookscripts doing weird stuff with output. query-migrate-hook can be used to query the current state of the running hookscript. After the migrate-hook has finished it also transfers the output back to the source node. When an error occurs, the query-migrate-hook command informs the caller and returns the respective output as well. Signed-off-by: Stefan Hanreich --- PVE/CLI/qm.pm | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 109 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index ca5d25f..5ac091b 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -306,6 +306,8 @@ __PACKAGE__->register_method ({ $tunnel_write->("tunnel online"); $tunnel_write->("ver 1"); + my $state = {}; + while (my $line = ) { chomp $line; if ($line =~ /^quit$/) { @@ -323,6 +325,113 @@ __PACKAGE__->register_method ({ } else { $tunnel_write->("ERR: resume failed - VM $vmid not running"); } + } elsif ($line =~ /^migrate-hook (\d+) (pre|post) ([\S]+) ([\S]+)$/) { + if ($state->{migrate_hook}) { + $tunnel_write->("ERR: migrate-hook is already running!"); + next; + } + + my $vmid = $1; + my $phase = $2; + my $source = $3; + my $target = $4; + + if (!PVE::JSONSchema::pve_verify_node_name($source, 1)) { + $tunnel_write->("ERR: Invalid name for source node"); + next; + } + + if (!PVE::JSONSchema::pve_verify_node_name($target, 1)) { + $tunnel_write->("ERR: Invalid name for target node"); + next; + } + + my $config_node = ($phase eq 'pre') + ? $source + : $target; + + eval { + my $conf = PVE::QemuConfig->load_config($vmid, $config_node); + + pipe(my $reader, my $writer); + + my $pid = fork(); + die "Could not fork new process!" if !defined $pid; + + if ($pid == 0) { + # child + close $reader; + + $ENV{PVE_MIGRATED_FROM} = $source; + + eval { + PVE::GuestHelpers::exec_hookscript( + $conf, + $vmid, + "$phase-migrate", + 1, + { + output => ">&" . fileno($writer), + errfunc => sub { + my $error_line = shift; + print $writer "STDERR: " . $error_line; + }, + } + ); + }; + my $err = $@; + + close $writer; + + if ($err) { + POSIX::_exit(1); + } + + POSIX::_exit(0); + } + + close $writer; + + $state->{migrate_hook} = { + output => $reader, + pid => $pid, + }; + }; + if ($@) { + chomp $@; + $tunnel_write->("ERR: $phase-migrate hook failed - $@"); + } else { + $tunnel_write->("OK"); + } + } elsif ($line =~ /^query-migrate-hook$/) { + if (!$state->{migrate_hook}) { + $tunnel_write->("ERR: No migration hook running!"); + next; + } + + if (!waitpid($state->{migrate_hook}->{pid}, POSIX::WNOHANG)) { + $tunnel_write->("OK"); + $tunnel_write->("running"); + next; + } + + my $reader = $state->{migrate_hook}->{output}; + my $output = ""; + + while (my $line = <$reader>) { + $output .= $line; + } + + close $state->{migrate_hook}->{output}; + delete $state->{migrate_hook}; + + my $status = ($? == 0) + ? 'finished' + : 'error'; + + $tunnel_write->("OK"); + $tunnel_write->("$status"); + $tunnel_write->(MIME::Base64::encode($output, '')); } } -- 2.30.2