From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9D1F7922C1 for ; Mon, 3 Oct 2022 15:52:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E72F3224F for ; Mon, 3 Oct 2022 15:52:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 3 Oct 2022 15:52:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3D9A444619 for ; Mon, 3 Oct 2022 15:52:15 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 3 Oct 2022 15:52:03 +0200 Message-Id: <20221003135211.183340-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES qemu(-server)/guest-common/manager/docs] make QEMU's max-workers setting configurable as a vzdump setting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2022 13:52:48 -0000 A few users reported IO-related issues during backup after upgrading to PVE 7.x and using a modified QEMU build with max-workers reduced to 8 instead of 16 helped them [0]. Other BackupPerf settings are not exposed, see the qemu patch for why. Introduces a more general 'performance' property string as a vzdump setting to be expanded in the future. And in the long run, existing performance settings like bwlimit could be moved into there. To detect if the currently running QEMU supports the setting, the query-proxmox-support QMP command is used. If not supported, a warning is printed and the setting is ignored. All but the last documentation patches are independent. The recently created dedicated section for jobs is expanded and the introductory section for backups is updated to mention PBS. The last patch mentions the new performance/max-workers setting. [0]: https://forum.proxmox.com/threads/113790/ Dependency bump manager -> guest-common is needed for the new $PROPERTY_STRING hash. qemu: Fiona Ebner (1): PVE Backup: allow passing max-workers performance setting block/monitor/block-hmp-cmds.c | 4 +++- pve-backup.c | 18 +++++++++++++----- qapi/block-core.json | 9 +++++++-- 3 files changed, 23 insertions(+), 8 deletions(-) guest-common: Fiona Ebner (1): vzdump: add 'performance' property string as a setting src/PVE/VZDump/Common.pm | 42 ++++++++++++++++++++++++++++++---------- 1 file changed, 32 insertions(+), 10 deletions(-) qemu-server: Fiona Ebner (1): vzdump: set max-workers QMP option when specified and supported PVE/VZDump/QemuServer.pm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) manager: Fiona Ebner (1): vzdump: handle new 'performance' property string PVE/API2/VZDump.pm | 9 +++++---- PVE/Jobs/VZDump.pm | 23 ++++++++++------------- PVE/VZDump.pm | 12 ++++++++++++ configs/vzdump.conf | 1 + www/manager6/dc/Backup.js | 8 +++++--- 5 files changed, 33 insertions(+), 20 deletions(-) docs: Fiona Ebner (4): backup: rework storage section, mentioning and recommending PBS backup: expand section for jobs backup: merge sections describing jobs backup: mention max-workers performance setting vzdump.adoc | 61 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 40 insertions(+), 21 deletions(-) -- 2.30.2