From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6879891644 for ; Wed, 28 Sep 2022 11:38:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A1F226FDC for ; Wed, 28 Sep 2022 11:38:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 28 Sep 2022 11:38:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 859F344620 for ; Wed, 28 Sep 2022 11:38:17 +0200 (CEST) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Wed, 28 Sep 2022 11:37:55 +0200 Message-Id: <20220928093756.3275614-2-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220928093756.3275614-1-s.hrdlicka@proxmox.com> References: <20220928093756.3275614-1-s.hrdlicka@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-manager 1/2] fix #1981: get next free disk id on change of bus/device X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2022 09:38:49 -0000 Signed-off-by: Stefan Hrdlicka --- FYI: When IDE already has 4 devices and the user tries to add another one, the number device number isn't changed since there isn't any space left. www/manager6/form/ControllerSelector.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index d84c49d6..6daede95 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/manager6/form/ControllerSelector.js @@ -12,7 +12,9 @@ Ext.define('PVE.form.ControllerSelector', { let freeId = PVE.Utils.nextFreeDisk(controllers, me.vmconfig); if (freeId !== undefined) { - busField.setValue(freeId.controller); + if (busField !== undefined) { + busField.setValue(freeId.controller); + } deviceIDField.setValue(freeId.id); } }, @@ -83,6 +85,7 @@ Ext.define('PVE.form.ControllerSelector', { return; } let field = me.down('field[name=deviceid]'); + me.setToFree([value], undefined, field); field.setMaxValue(PVE.Utils.diskControllerMaxIDs[value] - 1); field.validate(); }, -- 2.30.2