From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0CBD390CB5 for ; Fri, 23 Sep 2022 11:56:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DFB35234FB for ; Fri, 23 Sep 2022 11:55:30 +0200 (CEST) Received: from lana.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Fri, 23 Sep 2022 11:55:29 +0200 (CEST) Received: by lana.proxmox.com (Postfix, from userid 10043) id C51C62C21CB; Fri, 23 Sep 2022 11:55:29 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 23 Sep 2022 11:55:26 +0200 Message-Id: <20220923095529.2089346-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.141 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH qemu-server/pve-container/pve-docs 0/1] Add pre/post-clone hooks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 09:56:01 -0000 This patch adds pre/post-clone hooks when the when the user clones a CT/VM from the Web UI / CLI. I have tested this with both VMs/CTs via Web UI and CLI. Are there any other places where the hook should get triggered that I missed? Clone is a bit special since it can either target the same node or a different node. In the second case, we could also add additional events that fire on the respective target machine (pre/post-clone-target). In this case the other events should also be called (pre/post-clone-source) I think. Not sure if there is a use case for this though. For now we only run the hooks on the source machine, I think this should suffice. What do you think? pve-container: Stefan Hanreich (1): Add CT hooks for pre/post-clone src/PVE/API2/LXC.pm | 4 ++++ 1 file changed, 4 insertions(+) pve-docs: Stefan Hanreich (1): add pre/post-clone events to example hookscript examples/guest-example-hookscript.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+) qemu-server: Stefan Hanreich (1): Add VM hooks for pre/post-clone PVE/API2/Qemu.pm | 4 ++++ 1 file changed, 4 insertions(+) -- 2.30.2