From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 049CD938F5 for ; Mon, 19 Sep 2022 11:16:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F17521DD for ; Mon, 19 Sep 2022 11:16:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Sep 2022 11:16:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B59C043311 for ; Mon, 19 Sep 2022 11:16:49 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 19 Sep 2022 11:16:21 +0200 Message-Id: <20220919091621.29538-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220919091621.29538-1-f.ebner@proxmox.com> References: <20220919091621.29538-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2022 09:16:58 -0000 Namely, use "ISO storage" instead of "Storage". Relevant when inside the wizard, to avoid any confusion, but doesn't really feel wrong in the normal edit window either. Suggested in the community forum: https://forum.proxmox.com/threads/75219/post-498758 Signed-off-by: Fiona Ebner --- I feel like the first patch might already be enough, but this would drive home the point. www/manager6/qemu/CDEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js index f409fa53..33c12d43 100644 --- a/www/manager6/qemu/CDEdit.js +++ b/www/manager6/qemu/CDEdit.js @@ -118,7 +118,7 @@ Ext.define('PVE.qemu.CDInputPanel', { me.cdstoragesel = Ext.create('PVE.form.StorageSelector', { name: 'cdstorage', nodename: me.nodename, - fieldLabel: gettext('Storage'), + fieldLabel: gettext('ISO storage'), labelAlign: 'right', storageContent: 'iso', allowBlank: false, -- 2.30.2