From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2375691236 for ; Wed, 7 Sep 2022 11:46:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CF6A793 for ; Wed, 7 Sep 2022 11:46:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 7 Sep 2022 11:46:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D090D43EAC for ; Wed, 7 Sep 2022 11:37:45 +0200 (CEST) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Wed, 7 Sep 2022 11:37:40 +0200 Message-Id: <20220907093740.172217-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit] fix: toolkit: make email regex pattern match pve-common X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2022 09:46:39 -0000 `proxmoxMail` used its own regex pattern to validate emails. that meant certain email addresses were rejected by the front-end that were accepted by the backend that uses the functionality from `pve-common`. examples include the following: - "user@host.test-tld" - "user-@host.testtld" - "user@host" reported on the forum: https://forum.proxmox.com/threads/gui-bugulance-using-the-user-add-gui-interface.114743/ Signed-off-by: Stefan Sterz --- note that there are many many regex patterns that could be used (e.g.: [1]). im partial to w3c's approach [2], mainly because it's likely to be widely used, while being fairly simple and compatible with perl and javascript. [1]: https://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html [2]: https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address src/Toolkit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Toolkit.js b/src/Toolkit.js index ad64f89..c730374 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -131,9 +131,9 @@ Ext.apply(Ext.form.field.VTypes, { }, DnsNameOrWildcardText: gettext('This is not a valid DNS name'), - // workaround for https://www.sencha.com/forum/showthread.php?302150 + // email regex used by pve-common proxmoxMail: function(v) { - return (/^(\w+)([-+.][\w]+)*@(\w[-\w]*\.){1,5}([A-Za-z]){2,63}$/).test(v); + return (/^[\w+-~]+(\.[\w+-~]+)*@[a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)*$/).test(v); }, proxmoxMailText: gettext('Example') + ": user@example.com", -- 2.30.2