From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 48BCC906EC for ; Fri, 2 Sep 2022 09:33:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 38ADE2CEDD for ; Fri, 2 Sep 2022 09:33:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 2 Sep 2022 09:33:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 67493433D8 for ; Fri, 2 Sep 2022 09:33:11 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 2 Sep 2022 09:33:07 +0200 Message-Id: <20220902073307.31429-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220902073307.31429-1-f.ebner@proxmox.com> References: <20220902073307.31429-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 storage 2/2] RBD plugin: librados connect: increase timeout when in worker X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2022 07:33:12 -0000 The default timeout in PVE/RADOS.pm is 5 seconds, but this is not always enough for external clusters under load. Workers can and should take their time to not fail here too quickly. Signed-off-by: Fiona Ebner --- Changes from v1: * Add missing use statement. Was transitively used via e.g. PVE::RADOS, so it still worked, but let's be explicit about it. PVE/Storage/RBDPlugin.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 0d6f596..d76d5d3 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -13,6 +13,7 @@ use PVE::Cluster qw(cfs_read_file);; use PVE::JSONSchema qw(get_standard_option); use PVE::ProcFSTools; use PVE::RADOS; +use PVE::RPCEnvironment; use PVE::Storage::Plugin; use PVE::Tools qw(run_command trim file_read_firstline); @@ -27,6 +28,9 @@ my $get_parent_image_name = sub { my $librados_connect = sub { my ($scfg, $storeid, $options) = @_; + $options->{timeout} = 60 + if !defined($options->{timeout}) && PVE::RPCEnvironment->is_worker(); + my $librados_config = PVE::CephConfig::ceph_connect_option($scfg, $storeid, $options->%*); my $rados = PVE::RADOS->new(%$librados_config); -- 2.30.2