From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 844938CB8B for ; Mon, 29 Aug 2022 12:55:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6A47C2551F for ; Mon, 29 Aug 2022 12:55:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 29 Aug 2022 12:55:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D3FB943BF8 for ; Mon, 29 Aug 2022 12:54:57 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 29 Aug 2022 12:54:54 +0200 Message-Id: <20220829105454.55135-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server] snapshot: save VM state: propagate error from QEMU X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2022 10:55:36 -0000 So that there is a better chance to debug issues like in [0]. For suspending, which uses the same QMP calls, this is already done. [0]: https://forum.proxmox.com/threads/114203/ Signed-off-by: Fiona Ebner --- PVE/QemuConfig.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index cfef8d37..b75227b5 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -327,6 +327,9 @@ sub __snapshot_create_vol_snapshots_hook { my ($b, $t) = $render_state->($stat); print "completed saving the VM state in $t, saved $b\n"; last; + } elsif ($stat->{status} eq 'failed') { + my $err = $stat->{error} || 'unknown error'; + die "unable to save VM state and RAM - $err\n"; } else { die "query-savevm returned unexpected status '$stat->{status}'\n"; } -- 2.30.2