From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4A50E8996A for ; Fri, 12 Aug 2022 14:07:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B09128CE1 for ; Fri, 12 Aug 2022 14:07:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Aug 2022 14:07:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0BCBD44024 for ; Fri, 12 Aug 2022 14:07:11 +0200 (CEST) Date: Fri, 12 Aug 2022 14:07:10 +0200 From: Wolfgang Bumiller To: Dominik Csapak Cc: pve-devel@lists.proxmox.com Message-ID: <20220812120710.avvonkd7lsek3x6l@casey.proxmox.com> References: <20220812092951.2053040-1-d.csapak@proxmox.com> <20220812092951.2053040-5-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220812092951.2053040-5-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.276 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [data.name] Subject: [pve-devel] applied: [PATCH manager v2 1/1] ui: improve form/MDevSelector X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2022 12:07:46 -0000 applied, thanks On Fri, Aug 12, 2022 at 11:29:51AM +0200, Dominik Csapak wrote: > by > * showing the (optional) name in front of the type > * making the 'availble' column a bit narrower > * enabling 'cellWrap' for the description > * making the dropdown a bit wider (so all the information can fit) > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/MDevSelector.js | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/form/MDevSelector.js b/www/manager6/form/MDevSelector.js > index 8ee73c0c..0a157813 100644 > --- a/www/manager6/form/MDevSelector.js > +++ b/www/manager6/form/MDevSelector.js > @@ -16,21 +16,29 @@ Ext.define('PVE.form.MDevSelector', { > valueField: 'type', > displayField: 'type', > listConfig: { > + width: 550, > columns: [ > { > header: gettext('Type'), > dataIndex: 'type', > + renderer: function(value, md, rec) { > + if (rec.data.name !== undefined) { > + return `${rec.data.name} (${value})`; > + } > + return value; > + }, > flex: 1, > }, > { > - header: gettext('Available'), > + header: gettext('Avail.'), > dataIndex: 'available', > - width: 80, > + width: 60, > }, > { > header: gettext('Description'), > dataIndex: 'description', > flex: 1, > + cellWrap: true, > renderer: function(value) { > if (!value) { > return ''; > -- > 2.30.2