From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 189EC88DAB for ; Wed, 10 Aug 2022 17:10:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0AD9A19C43 for ; Wed, 10 Aug 2022 17:10:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Aug 2022 17:10:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 65F8843345 for ; Wed, 10 Aug 2022 17:10:21 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 10 Aug 2022 17:10:19 +0200 Message-Id: <20220810151020.573769-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 1/2] ui: CephInstallWizard: make first mon node static X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 15:10:29 -0000 Removes the possibility to select the node on which to create the first monitor in the configuration / initialization step and always sets it to the current node. This prevents that a user might select another node on which the Ceph packages have not yet been installed. If a user did that, they would get an error, but the Ceph config file would have been written. If the user then does not select a valid node to create the first mon, but aborts the wizard, they are greeted with a rados_connect error because the config file exists, but it does not contain any mon infos that are needed to connect to the Ceph cluster. Creating a mon manually will remedy such a situation, but especially for new users, this behavior is not ideal and confusing. Signed-off-by: Aaron Lauterer --- www/manager6/ceph/CephInstallWizard.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 79b0f4e4..b19d1a5e 100644 --- a/www/manager6/ceph/CephInstallWizard.js +++ b/www/manager6/ceph/CephInstallWizard.js @@ -401,11 +401,11 @@ Ext.define('PVE.ceph.CephInstallWizard', { value: gettext('First Ceph monitor') + ':', }, { - xtype: 'pveNodeSelector', + xtype: 'displayfield', fieldLabel: gettext('Monitor node'), - name: 'mon-node', - selectCurNode: true, - allowBlank: false, + cbind: { + value: '{nodename}', + }, }, { xtype: 'displayfield', @@ -461,8 +461,6 @@ Ext.define('PVE.ceph.CephInstallWizard', { var wizard = me.up('window'); var kv = wizard.getValues(); delete kv.delete; - var monNode = kv['mon-node']; - delete kv['mon-node']; var nodename = me.nodename; delete kv.nodename; Proxmox.Utils.API2Request({ @@ -472,7 +470,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { params: kv, success: function() { Proxmox.Utils.API2Request({ - url: `/nodes/${monNode}/ceph/mon/${monNode}`, + url: `/nodes/${nodename}/ceph/mon/${nodename}`, waitMsgTarget: wizard, method: 'POST', success: function() { -- 2.30.2