From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EC35F706BB for ; Fri, 22 Jul 2022 15:27:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E95993E11 for ; Fri, 22 Jul 2022 15:27:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Jul 2022 15:27:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 29CBA438BE for ; Fri, 22 Jul 2022 15:27:58 +0200 (CEST) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Fri, 22 Jul 2022 15:27:37 +0200 Message-Id: <20220722132738.397449-4-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220722132738.397449-1-d.tschlatscher@proxmox.com> References: <20220722132738.397449-1-d.tschlatscher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 4/4] VM start Timeout "Options" parameter in the GUI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 13:28:00 -0000 This makes it possible to set the newly introduced config parameter for timeout via the 'startoptions' property string. For now this only implements setting the timeout value when starting a VM, though this should be rather easily exentensible to include other future start options parameters. Signed-off-by: Daniel Tschlatscher --- Changes from v1: * Now uses a property string to encode the timeout www/manager6/qemu/Options.js | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js index a1def4bb..27b3ad93 100644 --- a/www/manager6/qemu/Options.js +++ b/www/manager6/qemu/Options.js @@ -76,6 +76,37 @@ Ext.define('PVE.qemu.Options', { onlineHelp: 'qm_startup_and_shutdown', } : undefined, }, + startoptions: { + header: gettext('VM startup options'), + defaultValue: Proxmox.Utils.defaultText, + renderer: val => val, + editor: caps.vms['VM.Config.Options'] ? { + xtype: 'proxmoxWindowEdit', + subject: gettext('VM start timeout'), + setValues: function(values) { + Ext.Array.each(this.query('inputpanel'), function(panel) { + panel.setValues(PVE.Parser.parsePropertyString(values.startoptions)); + }); + }, + items: { + xtype: 'inputpanel', + items: { + xtype: 'proxmoxintegerfield', + name: 'timeout', + minValue: 0, + maxValue: 86400, + fieldLabel: gettext('Timeout (sec)'), + emptyText: Proxmox.Utils.defaultText, + }, + onGetValues: function(values) { + if (values === undefined || Object.keys(values).length === 0) { + return { 'delete': 'startoptions' }; + } + return { 'startoptions': PVE.Parser.printPropertyString(values) }; + }, + }, + } : undefined, + }, ostype: { header: gettext('OS Type'), editor: caps.vms['VM.Config.Options'] ? 'PVE.qemu.OSTypeEdit' : undefined, -- 2.30.2