From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D33357DA55 for ; Fri, 22 Jul 2022 09:35:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C1F1A1FCEF for ; Fri, 22 Jul 2022 09:35:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Jul 2022 09:35:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 19E004254B for ; Fri, 22 Jul 2022 09:35:25 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 22 Jul 2022 09:35:24 +0200 Message-Id: <20220722073524.645810-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] form/RoleSelector: fix for pve X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 07:35:55 -0000 in pbs we get an array here, so the renderer is fine, but in pve it's just a long string, so add a space after commas to achieve the same effect. without this, the second column is not visible in pve because of an error in the renderer (no 'join' function on a string) Signed-off-by: Dominik Csapak --- src/form/RoleSelector.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/form/RoleSelector.js b/src/form/RoleSelector.js index d82c980..7d897f9 100644 --- a/src/form/RoleSelector.js +++ b/src/form/RoleSelector.js @@ -30,8 +30,15 @@ Ext.define('Proxmox.form.RoleSelector', { header: gettext('Privileges'), dataIndex: 'privs', cellWrap: true, - // join manually here, as ExtJS joins without whitespace which breaks cellWrap - renderer: v => v.join(', '), + renderer: (v) => { + if (Ext.isArray(v)) { + // join manually here, as ExtJS joins without whitespace which breaks cellWrap + return v.join(', '); + } + + // add space after comma for cellWrap + return v.replaceAll(',', ', '); + }, flex: 5, }, ], -- 2.30.2