From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AA1337D784; Thu, 21 Jul 2022 12:47:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A13DD6963; Thu, 21 Jul 2022 12:46:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Thu, 21 Jul 2022 12:46:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BB4AA4365D; Thu, 21 Jul 2022 12:46:34 +0200 (CEST) From: Matthias Heiserer To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Thu, 21 Jul 2022 12:45:57 +0200 Message-Id: <20220721104559.302270-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.176 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [smart.rs] Subject: [pve-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 10:47:05 -0000 This makes it consistent with the naming scheme in PVE/GUI. Keep value for API stability reasons, and remove it in next major version. Signed-off-by: Matthias Heiserer --- src/tools/disks/smart.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/tools/disks/smart.rs b/src/tools/disks/smart.rs index 3738cdfd..787971e9 100644 --- a/src/tools/disks/smart.rs +++ b/src/tools/disks/smart.rs @@ -25,8 +25,11 @@ pub enum SmartStatus { pub struct SmartAttribute { /// Attribute name name: String, - /// Attribute raw value + // fixme remove value in major release + /// duplicate of raw - kept for API stability value: String, + /// Attribute raw value + raw: String, // the rest of the values is available for ATA type /// ATA Attribute ID #[serde(skip_serializing_if = "Option::is_none")] @@ -146,7 +149,8 @@ pub fn get_smart_data(disk: &super::Disk, health_only: bool) -> Result Result