From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 295467B25B; Fri, 8 Jul 2022 11:16:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1ED7E26CE0; Fri, 8 Jul 2022 11:16:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Fri, 8 Jul 2022 11:16:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2825F41CAD; Fri, 8 Jul 2022 11:15:56 +0200 (CEST) Date: Fri, 8 Jul 2022 11:15:55 +0200 From: Wolfgang Bumiller To: Fabian Ebner Cc: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Message-ID: <20220708091555.zr3kufjoubjmks4i@wobu-vie.proxmox.com> References: <20220707103844.73931-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220707103844.73931-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.288 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 proxmox-perl-rs] move apt repositories module to common X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2022 09:16:06 -0000 On Thu, Jul 07, 2022 at 12:38:42PM +0200, Fabian Ebner wrote: > while introducing a 'product' parameter to the relevant functions and > adding wrappers for backwards-compatibility. > > Suggested-by: Wolfgang Bumiller > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * Add wrappers, so we can defer the Breaks to later. > * Drop unnecessary changes in Proxmox/Lib/Common.pm > > libproxmox-perl-rs needs a depends/breaks+replaces with both > libpve-rs-perl and libpmg-rs-perl, because it now includes the > P{MG,VE}/APT/Repositories.pm file. Oh I actually meant turning the rust side into wrappers, rather than adding perl wrappers, that way it wouldn't move into the common package and no depends/breaks would be required, unless I'm missing something? (...) > --- a/pve-rs/src/apt/repositories.rs > +++ /dev/null iow. keep this file/module around > @@ -1,162 +0,0 @@ (...) > -#[perlmod::package(name = "PVE::RS::APT::Repositories", lib = "pve_rs")] > -mod export { > - #[export] > - pub fn repositories() -> Result { but call out to the common code here in the `#[export]`s. because once we remove the wrappers we'll be adding more break entries still