From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 47DC77A56C for ; Mon, 4 Jul 2022 17:45:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C36E2889D for ; Mon, 4 Jul 2022 17:45:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 4 Jul 2022 17:45:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0150740EFF for ; Mon, 4 Jul 2022 17:45:27 +0200 (CEST) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Mon, 4 Jul 2022 17:45:17 +0200 Message-Id: <20220704154517.561889-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 15:45:58 -0000 when installing non-quincy versions, 'ceph-volume' is not contained in the respective repositories and, thus, the install process would fail. Signed-off-by: Stefan Sterz --- tested this by installing octopus, pacific and quincy. same issues as before. PVE/CLI/pveceph.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index a85df130..5c21bf7e 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm @@ -176,13 +176,17 @@ __PACKAGE__->register_method ({ my @ceph_packages = qw( ceph ceph-common - ceph-volume ceph-mds ceph-fuse gdisk nvme-cli ); + # when installing versions older than quincy, 'ceph-volume' does not exists. don't include it + if ($cephver ne 'octopus' and $cephver ne 'pacific') { + push @ceph_packages, 'ceph-volume'; + } + print "start installation\n"; # this flag helps to determine when apt is actually done installing (vs. partial extracing) -- 2.30.2