From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0F79278AA0 for ; Wed, 29 Jun 2022 13:07:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05F9724325 for ; Wed, 29 Jun 2022 13:07:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Jun 2022 13:07:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AC19A43D39 for ; Wed, 29 Jun 2022 13:07:15 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Wed, 29 Jun 2022 13:07:08 +0200 Message-Id: <20220629110708.904004-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.454 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH firewall] fix #4018: add firewall macro for SPICE X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 11:07:23 -0000 uses port 3128 (same as squid) although it's enabled by default for the "management" ipset, it doesn't hurt to add it in there. Signed-off-by: Oguz Bektas --- src/PVE/Firewall.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 71746d2..86985e0 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -494,6 +494,10 @@ my $pve_fw_macros = { { action => 'PARAM', proto => '41' }, { action => 'PARAM', proto => 'udp', dport => '5072,8374' }, ], + 'SPICE' => [ + "SPICE display proxy traffic", + { action => 'PARAM', proto => 'tcp', dport => '3128' }, + ], 'Squid' => [ "Squid web proxy traffic", { action => 'PARAM', proto => 'tcp', dport => '3128' }, -- 2.30.2