From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A74F788EB for ; Wed, 29 Jun 2022 11:08:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 642411B936 for ; Wed, 29 Jun 2022 11:08:44 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [185.151.191.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Jun 2022 11:08:42 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 8EC9FB49B; Wed, 29 Jun 2022 11:08:35 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 7559919B46B; Wed, 29 Jun 2022 11:08:35 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Wed, 29 Jun 2022 11:08:27 +0200 Message-Id: <20220629090833.456340-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.249 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH SERIES common/firewall/qemu-server/container 0/1] Cleanup use of PVE::Firewall X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 09:08:44 -0000 Hi, I was doing some profiling of qm && pct command, and I have found around 100ms cpu time just for the use of PVE::Firewall in qemu-server && pve-container for 2 small helpers. (clone_vmfw_conf && remove_vmfw_conf) as PVE::Firewall require QemuServer && LXC, we are loading full lxc in qm too. Also, LXC have some include of PVE::Firewall in different packages, not used, but it was magically including QemuServer, which including the json schema "pve-targetstorage", used by lxc too. I have moved this schema to main jsonschema in pve-common Alexandre Derumier (1): schema: add pve-targetstorage (moved from qemu-server) src/PVE/JSONSchema.pm | 7 +++++++ 1 file changed, 7 insertions(+) -- Alexandre Derumier (1): move clone_vmfw_conf && remove_vmfw_conf to a Helpers src/PVE/Firewall.pm | 25 ---------------------- src/PVE/Firewall/Helpers.pm | 41 +++++++++++++++++++++++++++++++++++++ src/PVE/Firewall/Makefile | 12 +++++++++++ src/PVE/Makefile | 2 ++ 4 files changed, 55 insertions(+), 25 deletions(-) create mode 100644 src/PVE/Firewall/Helpers.pm create mode 100644 src/PVE/Firewall/Makefile -- Alexandre Derumier (2): api2: use firewall helpers qemu-server: remove json schema pve-targetstorage (moved to pve-common) PVE/API2/Qemu.pm | 8 ++++---- PVE/QemuServer.pm | 7 ------- 2 files changed, 4 insertions(+), 11 deletions(-) -- Alexandre Derumier (2): remove unused use PVE::Firewall api2 : use firewall helpers src/PVE/API2/LXC.pm | 10 +++++----- src/PVE/API2/LXC/Config.pm | 1 - src/PVE/API2/LXC/Snapshot.pm | 1 - src/PVE/API2/LXC/Status.pm | 1 - 4 files changed, 5 insertions(+), 8 deletions(-) -- 2.30.2