From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 36B0B70AF4 for ; Wed, 22 Jun 2022 16:40:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34BDF1B8E2 for ; Wed, 22 Jun 2022 16:40:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 388B21B8D0 for ; Wed, 22 Jun 2022 16:40:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 101CC43C65 for ; Wed, 22 Jun 2022 16:40:02 +0200 (CEST) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Wed, 22 Jun 2022 16:39:26 +0200 Message-Id: <20220622143929.2757681-1-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.103 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH V2 manager 0/3] add iscsi, lvm, lvmthin & zfs storage on all cluster nodes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 14:40:04 -0000 The changes look huge only because the third commit changes all var statements to let. The relevant files for this change are: --- www/manager6/storage/Base.js | 42 ++++++++++++++++++++++ www/manager6/storage/IScsiEdit.js | 54 ++++++++++++++++++++++------- www/manager6/storage/LVMEdit.js | 21 +++++++++-- www/manager6/storage/LvmThinEdit.js | 35 ++++++++++++++----- www/manager6/storage/ZFSPoolEdit.js | 24 ++++++++++--- 5 files changed, 147 insertions(+), 29 deletions(-) V1 -> V2: # pve-storage * removed because patch is not needed # pve-manager (1/3) * remove storage controller from V1 * added custom ComboBox with API URL & setNodeName function * added scan node selection for iSCSI * scan node selection field no longer send to server ## (optional) pve-manager (2/3): cleanup related files * var to let statement change * some indentation ## ((very) optional) pve-manager (3/3): cleanup all var statements * replaces all var with let statements Stefan Hrdlicka (3): fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes cleanup: "var" to "let", fix some indentation in related files cleanup: "var" to "let" in all javascript files www/manager6/Parser.js | 8 +- www/manager6/StateProvider.js | 2 +- www/manager6/Utils.js | 139 +++++++++--------- www/manager6/VNCConsole.js | 10 +- www/manager6/Workspace.js | 12 +- www/manager6/button/ConsoleButton.js | 4 +- www/manager6/button/Split.js | 10 +- www/manager6/ceph/CephInstallWizard.js | 36 ++--- www/manager6/ceph/Config.js | 16 +- www/manager6/ceph/Crush.js | 6 +- www/manager6/ceph/FS.js | 6 +- www/manager6/ceph/Log.js | 6 +- www/manager6/ceph/Pool.js | 10 +- www/manager6/ceph/Services.js | 12 +- www/manager6/ceph/Status.js | 16 +- www/manager6/ceph/StatusDetail.js | 4 +- www/manager6/controller/StorageEdit.js | 4 +- www/manager6/data/PermPathStore.js | 2 +- www/manager6/data/ResourceStore.js | 4 +- www/manager6/dc/ACLView.js | 6 +- www/manager6/dc/ACMEPluginEdit.js | 2 +- www/manager6/dc/AuthEditBase.js | 4 +- www/manager6/dc/AuthView.js | 2 +- www/manager6/dc/Backup.js | 14 +- www/manager6/dc/BackupJobDetail.js | 10 +- www/manager6/dc/ClusterEdit.js | 6 +- www/manager6/dc/Config.js | 4 +- www/manager6/dc/GroupEdit.js | 6 +- www/manager6/dc/GroupView.js | 22 +-- www/manager6/dc/MetricServerView.js | 2 +- www/manager6/dc/NodeView.js | 2 +- www/manager6/dc/OptionView.js | 10 +- www/manager6/dc/PoolView.js | 22 +-- www/manager6/dc/RoleEdit.js | 10 +- www/manager6/dc/SecurityGroups.js | 10 +- www/manager6/dc/Summary.js | 20 +-- www/manager6/dc/Support.js | 16 +- www/manager6/dc/Tasks.js | 6 +- www/manager6/dc/UserEdit.js | 4 +- www/manager6/dc/UserView.js | 10 +- www/manager6/form/AgentFeatureSelector.js | 2 +- www/manager6/form/BridgeSelector.js | 6 +- www/manager6/form/BusTypeSelector.js | 2 +- www/manager6/form/CephFSSelector.js | 4 +- www/manager6/form/CephPoolSelector.js | 4 +- www/manager6/form/ContentTypeSelector.js | 2 +- www/manager6/form/ControllerSelector.js | 2 +- www/manager6/form/DayOfWeekSelector.js | 2 +- www/manager6/form/DiskStorageSelector.js | 24 +-- www/manager6/form/FileSelector.js | 8 +- www/manager6/form/GlobalSearchField.js | 14 +- www/manager6/form/GroupSelector.js | 4 +- www/manager6/form/GuestIDSelector.js | 12 +- www/manager6/form/HotplugFeatureSelector.js | 6 +- www/manager6/form/IPRefSelector.js | 10 +- www/manager6/form/MDevSelector.js | 8 +- www/manager6/form/MemoryField.js | 32 ++-- www/manager6/form/NodeSelector.js | 2 +- www/manager6/form/PCISelector.js | 6 +- www/manager6/form/PoolSelector.js | 4 +- www/manager6/form/QemuBiosSelector.js | 2 +- www/manager6/form/SDNControllerSelector.js | 4 +- www/manager6/form/SDNDnsSelector.js | 4 +- www/manager6/form/SDNIpamSelector.js | 4 +- www/manager6/form/SDNVnetSelector.js | 4 +- www/manager6/form/SDNZoneSelector.js | 4 +- www/manager6/form/SecurityGroupSelector.js | 4 +- www/manager6/form/SnapshotSelector.js | 6 +- www/manager6/form/SpiceEnhancementSelector.js | 8 +- www/manager6/form/StorageSelector.js | 8 +- www/manager6/form/USBSelector.js | 6 +- www/manager6/form/VLanField.js | 4 +- www/manager6/form/VMCPUFlagSelector.js | 30 ++-- www/manager6/form/VMSelector.js | 12 +- www/manager6/grid/BackupView.js | 36 ++--- www/manager6/grid/FirewallAliases.js | 4 +- www/manager6/grid/FirewallOptions.js | 18 +-- www/manager6/grid/FirewallRules.js | 64 ++++---- www/manager6/grid/PoolMembers.js | 32 ++-- www/manager6/grid/Replication.js | 20 +-- www/manager6/grid/ResourceGrid.js | 4 +- www/manager6/ha/Fencing.js | 4 +- www/manager6/ha/GroupEdit.js | 12 +- www/manager6/ha/GroupSelector.js | 2 +- www/manager6/ha/Groups.js | 10 +- www/manager6/ha/ResourceEdit.js | 28 ++-- www/manager6/ha/Status.js | 2 +- www/manager6/ha/StatusView.js | 8 +- www/manager6/lxc/Config.js | 42 +++--- www/manager6/lxc/CreateWizard.js | 2 +- www/manager6/lxc/DNS.js | 50 +++---- www/manager6/lxc/FeaturesEdit.js | 10 +- www/manager6/lxc/MPEdit.js | 8 +- www/manager6/lxc/MPResize.js | 18 +-- www/manager6/lxc/Options.js | 28 ++-- www/manager6/lxc/ResourceEdit.js | 14 +- www/manager6/lxc/Resources.js | 42 +++--- www/manager6/node/ACME.js | 16 +- www/manager6/node/Certificates.js | 4 +- www/manager6/node/Config.js | 20 +-- www/manager6/node/Directory.js | 2 +- www/manager6/node/LVMThin.js | 2 +- www/manager6/node/StatusView.js | 4 +- www/manager6/node/Subscription.js | 34 ++--- www/manager6/node/Summary.js | 18 +-- www/manager6/node/ZFS.js | 4 +- www/manager6/panel/ConfigPanel.js | 58 ++++---- www/manager6/panel/GuestStatusView.js | 16 +- www/manager6/panel/GuestSummary.js | 16 +- www/manager6/panel/HealthWidget.js | 4 +- www/manager6/panel/IPSet.js | 62 ++++---- www/manager6/panel/RunningChart.js | 4 +- www/manager6/panel/StatusPanel.js | 14 +- www/manager6/panel/TemplateStatusView.js | 4 +- www/manager6/pool/Config.js | 4 +- www/manager6/pool/StatusView.js | 6 +- www/manager6/pool/Summary.js | 8 +- www/manager6/qemu/AgentIPView.js | 40 ++--- www/manager6/qemu/AudioEdit.js | 6 +- www/manager6/qemu/CDEdit.js | 32 ++-- www/manager6/qemu/CIDriveEdit.js | 16 +- www/manager6/qemu/CloudInit.js | 68 ++++----- www/manager6/qemu/Config.js | 52 +++---- www/manager6/qemu/CreateWizard.js | 14 +- www/manager6/qemu/HDEdit.js | 38 ++--- www/manager6/qemu/HDEfi.js | 12 +- www/manager6/qemu/HDResize.js | 14 +- www/manager6/qemu/HDTPM.js | 14 +- www/manager6/qemu/HardwareView.js | 58 ++++---- www/manager6/qemu/IPConfigEdit.js | 24 +-- www/manager6/qemu/KeyboardEdit.js | 2 +- www/manager6/qemu/MemoryEdit.js | 32 ++-- www/manager6/qemu/Monitor.js | 39 ++--- www/manager6/qemu/NetworkEdit.js | 24 +-- www/manager6/qemu/OSDefaults.js | 2 +- www/manager6/qemu/OSTypeEdit.js | 20 +-- www/manager6/qemu/Options.js | 36 ++--- www/manager6/qemu/PCIEdit.js | 8 +- www/manager6/qemu/ProcessorEdit.js | 18 +-- www/manager6/qemu/RNGEdit.js | 6 +- www/manager6/qemu/SSHKey.js | 12 +- www/manager6/qemu/ScsiHwEdit.js | 2 +- www/manager6/qemu/SerialEdit.js | 12 +- www/manager6/qemu/Smbios1Edit.js | 14 +- www/manager6/qemu/SystemEdit.js | 4 +- www/manager6/qemu/USBEdit.js | 20 +-- www/manager6/sdn/Browser.js | 8 +- www/manager6/sdn/ControllerView.js | 6 +- www/manager6/sdn/Status.js | 2 +- www/manager6/sdn/StatusView.js | 8 +- www/manager6/sdn/SubnetEdit.js | 2 +- www/manager6/sdn/SubnetView.js | 2 +- www/manager6/sdn/VnetEdit.js | 2 +- www/manager6/sdn/VnetPanel.js | 6 +- www/manager6/sdn/VnetView.js | 2 +- www/manager6/sdn/ZoneContentView.js | 14 +- www/manager6/sdn/ZoneView.js | 2 +- www/manager6/sdn/controllers/Base.js | 10 +- www/manager6/sdn/controllers/BgpEdit.js | 4 +- www/manager6/sdn/controllers/EvpnEdit.js | 2 +- www/manager6/sdn/dns/Base.js | 12 +- www/manager6/sdn/dns/PowerdnsEdit.js | 4 +- www/manager6/sdn/ipams/Base.js | 12 +- www/manager6/sdn/ipams/NetboxEdit.js | 4 +- www/manager6/sdn/ipams/PVEIpamEdit.js | 4 +- www/manager6/sdn/ipams/PhpIpamEdit.js | 4 +- www/manager6/sdn/zones/Base.js | 12 +- www/manager6/sdn/zones/EvpnEdit.js | 4 +- www/manager6/sdn/zones/SimpleEdit.js | 4 +- www/manager6/sdn/zones/VlanEdit.js | 4 +- www/manager6/sdn/zones/VxlanEdit.js | 4 +- www/manager6/storage/BackupView.js | 16 +- www/manager6/storage/Base.js | 54 ++++++- www/manager6/storage/Browser.js | 8 +- www/manager6/storage/CIFSEdit.js | 12 +- www/manager6/storage/CephFSEdit.js | 2 +- www/manager6/storage/ContentView.js | 4 +- www/manager6/storage/DirEdit.js | 2 +- www/manager6/storage/GlusterFsEdit.js | 12 +- www/manager6/storage/IScsiEdit.js | 60 ++++++-- www/manager6/storage/ImageView.js | 22 +-- www/manager6/storage/LVMEdit.js | 35 +++-- www/manager6/storage/LvmThinEdit.js | 53 ++++--- www/manager6/storage/NFSEdit.js | 24 +-- www/manager6/storage/PBSEdit.js | 2 +- www/manager6/storage/RBDEdit.js | 12 +- www/manager6/storage/Summary.js | 10 +- www/manager6/storage/TemplateView.js | 36 ++--- www/manager6/storage/ZFSEdit.js | 6 +- www/manager6/storage/ZFSPoolEdit.js | 47 +++--- www/manager6/tree/SnapshotTree.js | 12 +- www/manager6/window/Backup.js | 18 +-- www/manager6/window/BackupConfig.js | 4 +- www/manager6/window/BulkAction.js | 16 +- www/manager6/window/Clone.js | 38 ++--- www/manager6/window/DownloadUrlToStorage.js | 4 +- www/manager6/window/FirewallEnableEdit.js | 2 +- www/manager6/window/FirewallLograteEdit.js | 2 +- www/manager6/window/LoginWindow.js | 62 ++++---- www/manager6/window/Migrate.js | 16 +- www/manager6/window/Prune.js | 6 +- www/manager6/window/Settings.js | 26 ++-- www/manager6/window/Snapshot.js | 4 +- www/manager6/window/StartupEdit.js | 10 +- www/manager6/window/Wizard.js | 4 +- 205 files changed, 1522 insertions(+), 1403 deletions(-) -- 2.30.2