From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 19FC970AD4 for ; Wed, 22 Jun 2022 16:13:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 181D71ABC9 for ; Wed, 22 Jun 2022 16:13:39 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [IPv6:2a0a:1580:2000::2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 53E521ABA6 for ; Wed, 22 Jun 2022 16:13:37 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 1BE4417444; Wed, 22 Jun 2022 16:13:37 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 06373168938; Wed, 22 Jun 2022 16:13:37 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Wed, 22 Jun 2022 16:13:34 +0200 Message-Id: <20220622141335.3616129-2-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220622141335.3616129-1-aderumier@odiso.com> References: <20220622141335.3616129-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 pve-manager 1/2] ui: cloudinit : use new cloudinit config api X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 14:13:39 -0000 Signed-off-by: Alexandre Derumier --- www/manager6/qemu/CloudInit.js | 82 +++++++++++++++------------------- 1 file changed, 36 insertions(+), 46 deletions(-) diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js index 77ff93d4..f2ad77a8 100644 --- a/www/manager6/qemu/CloudInit.js +++ b/www/manager6/qemu/CloudInit.js @@ -82,38 +82,16 @@ Ext.define('PVE.qemu.CloudInit', { text: gettext('Regenerate Image'), handler: function() { let view = this.up('grid'); - var eject_params = {}; - var insert_params = {}; - let disk = PVE.Parser.parseQemuDrive(view.ciDriveId, view.ciDrive); - var storage = ''; - var stormatch = disk.file.match(/^([^:]+):/); - if (stormatch) { - storage = stormatch[1]; - } - eject_params[view.ciDriveId] = 'none,media=cdrom'; - insert_params[view.ciDriveId] = storage + ':cloudinit'; - - var failure = function(response, opts) { - Ext.Msg.alert('Error', response.htmlStatus); - }; Proxmox.Utils.API2Request({ - url: view.baseurl + '/config', + url: view.baseurl + '/cloudinit', waitMsgTarget: view, method: 'PUT', - params: eject_params, - failure: failure, + failure: function(response, opts) { + Ext.Msg.alert('Error', response.htmlStatus); + }, callback: function() { - Proxmox.Utils.API2Request({ - url: view.baseurl + '/config', - waitMsgTarget: view, - method: 'PUT', - params: insert_params, - failure: failure, - callback: function() { - view.reload(); - }, - }); + view.reload(); }, }); }, @@ -133,13 +111,20 @@ Ext.define('PVE.qemu.CloudInit', { return; } var id = record.data.key; + var pending = record.data.pending; var value = record.data.value; var ciregex = new RegExp("vm-" + me.pveSelNode.data.vmid + "-cloudinit"); - if (id.match(/^(ide|scsi|sata)\d+$/) && ciregex.test(value)) { + if (id.match(/^(ide|scsi|sata)\d+$/)) { + if (ciregex.test(pending)) { + found = id; + me.ciDriveId = found; + me.ciDrive = pending; + } else if (ciregex.test(value)) { found = id; me.ciDriveId = found; me.ciDrive = value; } + } }); me.down('#savebtn').setDisabled(!found); @@ -188,12 +173,13 @@ Ext.define('PVE.qemu.CloudInit', { } var caps = Ext.state.Manager.get('GuiCap'); me.baseurl = '/api2/extjs/nodes/' + nodename + '/qemu/' + vmid; - me.url = me.baseurl + '/pending'; + me.url = me.baseurl + '/cloudinit'; me.editorConfig.url = me.baseurl + '/config'; me.editorConfig.pveSelNode = me.pveSelNode; let caps_ci = caps.vms['VM.Config.Cloudinit'] || caps.vms['VM.Config.Network']; /* editor is string and object */ + me.rows = { ciuser: { header: gettext('User'), @@ -239,6 +225,13 @@ Ext.define('PVE.qemu.CloudInit', { return value || Proxmox.Utils.noneText; }, }, + name: { + header: gettext('Hostname'), + iconCls: 'fa fa-globe', + editor: undefined, + never_delete: true, + defaultValue: '', + }, searchdomain: { header: gettext('DNS domain'), iconCls: 'fa fa-globe', @@ -288,35 +281,32 @@ Ext.define('PVE.qemu.CloudInit', { }, }; var i; - var ipconfig_renderer = function(value, md, record, ri, ci, store, pending) { - var id = record.data.key; - var match = id.match(/^net(\d+)$/); - var val = ''; - if (match) { - val = me.getObjectValue('ipconfig'+match[1], '', pending); - } - return val; - }; + for (i = 0; i < 32; i++) { - // we want to show an entry for every network device - // even if it is empty - me.rows['net' + i.toString()] = { - multiKey: ['ipconfig' + i.toString(), 'net' + i.toString()], + me.rows['ipconfig' + i.toString()] = { header: gettext('IP Config') + ' (net' + i.toString() +')', editor: caps.vms['VM.Config.Network'] ? 'PVE.qemu.IPConfigEdit' : undefined, iconCls: 'fa fa-exchange', - renderer: ipconfig_renderer, + visible: true, }; - me.rows['ipconfig' + i.toString()] = { - visible: false, + + me.rows['net' + i.toString()] = { + header: 'net' + i.toString(), + editor: undefined, + iconCls: 'fa fa-exchange', + never_delete: true, + visible: true, }; } PVE.Utils.forEachBus(['ide', 'scsi', 'sata'], function(type, id) { me.rows[type+id] = { - visible: false, + title: 'Cloud-Init', + iconCls: 'fa fa-cloud', + never_delete: true, }; }); + me.callParent(); me.mon(me.rstore, 'load', me.set_button_status, me); }, -- 2.30.2