From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9855C7098F for ; Wed, 22 Jun 2022 13:52:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DC84189BA for ; Wed, 22 Jun 2022 13:52:19 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [185.151.191.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DA9D4188EA for ; Wed, 22 Jun 2022 13:52:14 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 2BB2C7E9D; Wed, 22 Jun 2022 13:52:08 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 1888A12C959; Wed, 22 Jun 2022 13:52:08 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Wed, 22 Jun 2022 13:51:56 +0200 Message-Id: <20220622115206.3295425-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v7 qemu-server 00/10] cloudinit pending behaviour change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 11:52:50 -0000 Hi, This is an attempt to cleanup current behaviour of cloudinit online changes. Currently, we setup cloudinit options as pending, until we generate the config drive. This is not 100% true, because some option like vm name, nic mac address can be changed, without going to pending, so user can't known if it need to regenerated it. Also, some can are very difficult to handle, if you hotplug a nic but it's failing,so pending, then you defined an ipconfig, and then you revert hotplug. or if you delete a nic, the ipconfig is no more displayed in the gui. So, instead of setting cloudinit values in pending, this patch serie copy the current cloudinit config in a new section [special:cloudinit], when the config drive is generated. This is only an hint, to allow to display diff between the generated cloudinit drive, and the current vm config. A new specific cloudinit config api is added too displaying the diff between current and generated config. Reminder: This need pve-manager depency bump first to check the version for live migration. pve-manager patches series is available here : https://lists.proxmox.com/pipermail/pve-devel/2021-June/048542.html (I need to small fix to display nic/mac info, I'll try to fix it today) Changelog V1: - use [special:cloudinit] instead [CLOUDINIT] for section - delete config section on drive removal - config api: move code to new PVE::QemuServer::Cloudinit::get_pending_config - config api: add "qm cloudinit pending" cli - add update api to regenerate drive with 1 api call - add cloudinit hotplug option Changelog v2: - fix trailing whitespace in first patch - revert previous "cloudinit" check in snapshot name (":" character is already forbidden) Changelog v3: - extract the current conf from cloudinit drive instead write the special cloudinit section Changelog v4: - rebase on v2, keep current cloudinit config in vm configuration - pending api: display mac address change on netX - cleanup && fix from Fabian comments Changelog v5: - move cloudinit fast_plug_option generation outside vmconfig_hotplug_pending - remove cloudinit section from vm_config api - vzdump : skip cloudinit section - migration: check target node version && forbid migration if too old && cloudinit section exist. Changelog v6: - move last 3 patches at beginning of the patch series - api config: remove cloudinit in load_current_config - migration: move the 2 helpers in PVE::QemuServer::Helpers + code cleanup Changelog v7: - code cleanup - add an extra patch for debian control to break pve-manager <= 7.2.4 Alexandre Derumier (10): qemuconfig: load_current_config : delete cloudinit value vzdump : skip special:cloudinit section migration: test targetnode min version for cloudinit section cloudinit: add cloudinit section for current generated config. generate cloudinit drive on offline plug cloudinit: make cloudnit options fastplug api2: add cloudinit config api api2: add cloudinit_update add cloudinit hotplug debian : control : add a break on pve-manager <= 7.2.4 PVE/API2/Qemu.pm | 111 ++++++++++++++++++++++++++++++++++++ PVE/CLI/qm.pm | 2 + PVE/QemuConfig.pm | 8 +++ PVE/QemuMigrate.pm | 8 +++ PVE/QemuServer.pm | 100 ++++++++++++++++++++++---------- PVE/QemuServer/Cloudinit.pm | 110 +++++++++++++++++++++++++++++++++++ PVE/QemuServer/Helpers.pm | 24 ++++++++ PVE/VZDump/QemuServer.pm | 5 +- debian/control | 2 +- 9 files changed, 337 insertions(+), 33 deletions(-) -- 2.30.2