From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EC66A703A9 for ; Tue, 21 Jun 2022 11:20:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF9B32BDE for ; Tue, 21 Jun 2022 11:20:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B2CCE296E for ; Tue, 21 Jun 2022 11:20:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8C09843C3D for ; Tue, 21 Jun 2022 11:20:13 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 21 Jun 2022 11:19:48 +0200 Message-Id: <20220621092012.1776825-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm, datacenterconfig.pm, jsonschema.pm, cluster.pm, api2.pm, lxc.pm, qemuserver.pm, qemu.pm] Subject: [pve-devel] [PATCH common/cluster/qemu/container/wt/manager v7] add tags to ui X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 09:20:52 -0000 this series brings the already existing 'tags' for ct/vms to the gui: * tags can be edited in the status toolbar of the guest * existing tags will be shown in the tree/global search/resource grids * when editing a tag, a list of existing tags will be shown * by default, the color is (consistently) autogenerated based on the text * that color can be overriden in datacenter -> options (cluster wide) (edit window for browser local storage is TBD) * by default, the text color is either white or black, depending which provides the greater contrast (according to SAPC) * this text color can also be overridden * there are multiple shapes available for the tree (see [0]) * adds new 'admin' tags that need higher privliges, these can then be used to enable features like 'inlude in backup by tag', etc. i left the patches of the 'admin' tags seperate, so that we can decide if this is the right approach, but still apply some other parts. (pve-common 2/2, wt 2/3, qemu-server, pve-container, pve-manager 12/14) same with the gui patches for drag&drop, not sure if the ux is good enough. (wt 3/3, pve-manager: 14/14) sorry for the large series.... (i omitted the changeslogs up to v6, were getting a bit long ;) ) changes from v6: * reworded some commit messages * added small benchmark result to CFS_IPC_GET_GUEST_CONFIG_PROPERTIES commit msg * reshaped datacenter.cfg format into a property-string (also combined the gui edit window for shape+color override) * refactored the pve-tags regex in pve-common/JSONSchema * added admin tags ('+tag' syntax) with priv checks in qemu-sever/pve-container and subtle highlighting in the gui (bold-text) * added tag rendering in resource grids * add patches for drag&drop support when editing pve-common: Dominik Csapak (2): JSONSchema: refactor tag regex JSONSchema: pve-tag: add syntax for 'admin' tags src/PVE/JSONSchema.pm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) pve-cluster: Dominik Csapak (3): add CFS_IPC_GET_GUEST_CONFIG_PROPERTIES method Cluster: add get_guest_config_properties datacenter.cfg: add option for tag-style data/PVE/Cluster.pm | 27 ++++++ data/PVE/DataCenterConfig.pm | 37 ++++++++ data/src/cfs-ipc-ops.h | 2 + data/src/server.c | 64 +++++++++++++ data/src/status.c | 177 ++++++++++++++++++++++++----------- data/src/status.h | 3 + 6 files changed, 254 insertions(+), 56 deletions(-) proxmox-widget-Toolkit: Dominik Csapak (3): add tag related helpers add class for 'admin' tags Toolkit: add override for Ext.dd.DragDropManager src/Toolkit.js | 16 ++++++++ src/Utils.js | 94 ++++++++++++++++++++++++++++++++++++++++++++ src/css/ext6-pmx.css | 49 +++++++++++++++++++++++ 3 files changed, 159 insertions(+) qemu-server: Dominik Csapak (1): api: update: check 'admin' tags privileges PVE/API2/Qemu.pm | 56 ++++++++++++++++++++++++++++++++++++++++++++++- PVE/QemuServer.pm | 3 ++- 2 files changed, 57 insertions(+), 2 deletions(-) pve-container: Dominik Csapak (1): check_ct_modify_config_perm: check 'admin' tags privileges src/PVE/LXC.pm | 31 +++++++++++++++++++++++++++++++ src/PVE/LXC/Config.pm | 3 ++- 2 files changed, 33 insertions(+), 1 deletion(-) pve-manager: Dominik Csapak (14): api: /cluster/resources: add tags to returned properties api: /version: add 'tag-style' ui: parse and save tag color overrides from /version ui: tree/ResourceTree: collect tags on update ui: add form/TagColorGrid ui: dc/OptionView: add editors for tag settings ui: add form/Tag ui: add form/TagEdit.js ui: {lxc,qemu}/Config: show Tags and make them editable ui: tree/ResourceTree: show Tags in tree ui: form/GlobalSearchField: display tags and allow to search for them ui: form/Tag: add 'admin-tag' class to admin tags ui: ResourceGrid: render tags ui: form/Tag(Edit): add drag & drop when editing tags PVE/API2.pm | 7 +- PVE/API2/Cluster.pm | 9 +- www/css/ext6-pve.css | 5 + www/manager6/Makefile | 3 + www/manager6/Utils.js | 69 +++++ www/manager6/Workspace.js | 13 + www/manager6/data/ResourceStore.js | 9 + www/manager6/dc/OptionView.js | 84 ++++++ www/manager6/form/GlobalSearchField.js | 20 +- www/manager6/form/Tag.js | 294 ++++++++++++++++++++ www/manager6/form/TagColorGrid.js | 357 +++++++++++++++++++++++++ www/manager6/form/TagEdit.js | 245 +++++++++++++++++ www/manager6/grid/ResourceGrid.js | 1 + www/manager6/lxc/Config.js | 36 ++- www/manager6/qemu/Config.js | 35 ++- www/manager6/tree/ResourceTree.js | 20 +- 16 files changed, 1190 insertions(+), 17 deletions(-) create mode 100644 www/manager6/form/Tag.js create mode 100644 www/manager6/form/TagColorGrid.js create mode 100644 www/manager6/form/TagEdit.js -- 2.30.2