From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D57B71202 for ; Fri, 17 Jun 2022 10:42:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81138AD28 for ; Fri, 17 Jun 2022 10:42:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 955A7AD1C for ; Fri, 17 Jun 2022 10:42:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 62E0542EF3 for ; Fri, 17 Jun 2022 10:42:38 +0200 (CEST) Date: Fri, 17 Jun 2022 10:42:36 +0200 From: Wolfgang Bumiller To: Mira Limbeck Cc: pve-devel@lists.proxmox.com Message-ID: <20220617084236.aoss7otwx3ee6on7@wobu-vie.proxmox.com> References: <20220615140950.2586849-1-m.limbeck@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615140950.2586849-1-m.limbeck@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, ietf.org, openid.pm] Subject: Re: [pve-devel] [PATCH access-control] fix #4074: increase API OpenID code size limit to 2048 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 08:42:46 -0000 On Wed, Jun 15, 2022 at 04:09:50PM +0200, Mira Limbeck wrote: > Azure AD seems to have a variable authorization code size, depending on > the browser state according to one report in bug #4074 [0]. > > Sometimes the size is greater than our current limit of 1024, so > increase it to 2048. Would there be any downside to just going straight to 4 or 8K here? > > The RFC [1] mentions that there is no limit to the code size, but based on > current experience, a size limit of 2048 might be enough for every > current OpenID Connect provider. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4074 > [1] https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2 > > Signed-off-by: Mira Limbeck > --- > The PBS implementation doesn't seem to be using any code size limit, do > we want to remove it entirely in PVE as well? > > src/PVE/API2/OpenId.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm > index c838b2c..8653d61 100644 > --- a/src/PVE/API2/OpenId.pm > +++ b/src/PVE/API2/OpenId.pm > @@ -134,7 +134,7 @@ __PACKAGE__->register_method ({ > code => { > description => "OpenId authorization code.", > type => 'string', > - maxLength => 1024, > + maxLength => 2048, > }, > 'redirect-url' => { > description => "Redirection Url. The client should set this to the used server url (location.origin).", > -- > 2.30.2