From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C255E70DA3 for ; Wed, 15 Jun 2022 10:52:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE62A27DED for ; Wed, 15 Jun 2022 10:52:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 39DE927DE4 for ; Wed, 15 Jun 2022 10:52:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E70B43B4A for ; Wed, 15 Jun 2022 10:52:11 +0200 (CEST) Date: Wed, 15 Jun 2022 10:52:10 +0200 From: Wolfgang Bumiller To: Daniel Tschlatscher Cc: pve-devel@lists.proxmox.com Message-ID: <20220615085210.yajtniz67kwutxgi@wobu-vie.proxmox.com> References: <20220614090013.84500-1-d.tschlatscher@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614090013.84500-1-d.tschlatscher@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.309 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied series: [PATCH storage v4 1/4] fix #3972: Remove the .notes file when a backup is deleted X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 08:52:41 -0000 applied series and removed the empty lines between the S-o-b and R-b lines. On Tue, Jun 14, 2022 at 11:00:10AM +0200, Daniel Tschlatscher wrote: > When a VM or Container backup was deleted, the .notes file was not > removed, therefore, over time the dump folder would get polluted with > notes for backups that no longer existed. As backup names contain a > timestamp and as the notes cannot be reused because of this, I think > it is safe to just delete them just like we do with the .log file. > > Furthermore, I sourced the deletion of the log and notes file into a > new function called "archive_auxiliaries_remove". Additionally, the > archive_info object now returns one more field containing the name of > the notes file. The test cases have to be adapted to expect this new > value as the package will not compile otherwise. > > Signed-off-by: Daniel Tschlatscher > > Reviewed-by: Fabian Ebner