From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6A66570460 for ; Mon, 13 Jun 2022 15:54:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68629BCF2 for ; Mon, 13 Jun 2022 15:54:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 69925BCDA for ; Mon, 13 Jun 2022 15:54:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 38D7B43AE2 for ; Mon, 13 Jun 2022 15:54:31 +0200 (CEST) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Mon, 13 Jun 2022 15:54:25 +0200 Message-Id: <20220613135425.1800809-4-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220613135425.1800809-1-m.heiserer@proxmox.com> References: <20220613135425.1800809-1-m.heiserer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.194 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v5 qemu-server 2/2] fix #3890 - GUI: warn for unlikely iothread config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 13:54:32 -0000 Previously, only a plaintext line in the task log showed something was off. Now, the GUI will show it as a warning. Reviewed-by: Fabian Ebner Signed-off-by: Matthias Heiserer --- changes from v4: * reorder import alphabetically Changes from v3: * None changes from v2: * locally import PVE::RestEnv log_warn PVE/QemuServer.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e9aa248..aebfee8 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -36,6 +36,7 @@ use PVE::INotify; use PVE::JSONSchema qw(get_standard_option parse_property_string); use PVE::ProcFSTools; use PVE::PBSClient; +use PVE::RESTEnvironment qw(log_warn); use PVE::RPCEnvironment; use PVE::Storage; use PVE::SysFSTools; @@ -3961,7 +3962,9 @@ sub config_to_command { $iothread .= ",iothread=iothread-$controller_prefix$controller"; push @$cmd, '-object', "iothread,id=iothread-$controller_prefix$controller"; } elsif ($drive->{iothread}) { - warn "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n"; + log_warn( + "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n" + ); } my $queues = ''; -- 2.30.2