From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 99FAE704AA for ; Mon, 13 Jun 2022 15:55:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F53DBCF3 for ; Mon, 13 Jun 2022 15:54:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6EECDBCDF for ; Mon, 13 Jun 2022 15:54:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3EDFB43AF4 for ; Mon, 13 Jun 2022 15:54:31 +0200 (CEST) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Mon, 13 Jun 2022 15:54:22 +0200 Message-Id: <20220613135425.1800809-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v5 manager 1/2] GUI: HDEdit: check iothread by default and move it from advanced section X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 13:55:02 -0000 Existing disks are not changed by this. Especially in benchmarks, iothreads significantly improve IO performance. Signed-off-by: Matthias Heiserer --- Changes from v4: * also check iothread for VirtIO block devices Changes from v3: * remove automatically switching to/from SCSI single when iothread is (un)checked * iothread will be initially set on * changing the controller to something other than SCSI single and then back to SCSI single will enable iothread for all SCSI disks. Changes from v2: * also check iothread when adding a disk to an existing VM www/manager6/qemu/HDEdit.js | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 4e4d6aac..921bfe72 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -14,6 +14,7 @@ Ext.define('PVE.qemu.HDInputPanel', { data: { isSCSI: false, isVirtIO: false, + isSCSISingle: false, }, }, @@ -44,13 +45,10 @@ Ext.define('PVE.qemu.HDInputPanel', { 'field[name=deviceid]': { change: 'fireIdChange', }, - 'field[name=iothread]': { + 'field[name=scsiController]': { change: function(f, value) { - if (!this.getView().insideWizard) { - return; - } - var vmScsiType = value ? 'virtio-scsi-single': 'virtio-scsi-pci'; - this.lookupReference('scsiController').setValue(vmScsiType); + let vm = this.getViewModel(); + vm.set('isSCSISingle', value === 'virtio-scsi-single'); }, }, }, @@ -195,6 +193,7 @@ Ext.define('PVE.qemu.HDInputPanel', { me.scsiController = Ext.create('Ext.form.field.Display', { fieldLabel: gettext('SCSI Controller'), reference: 'scsiController', + name: 'scsiController', bind: me.insideWizard ? { value: '{current.scsihw}', visible: '{isSCSI}', @@ -251,6 +250,17 @@ Ext.define('PVE.qemu.HDInputPanel', { reference: 'discard', name: 'discard', }, + { + xtype: 'proxmoxcheckbox', + name: 'iothread', + fieldLabel: 'IO thread', + clearOnDisable: true, + bind: { + disabled: '{!isVirtIO && !isSCSI}', + // Checkbox.setValue handles Arrays in a different way, therefore cast to bool + value: '{!!isVirtIO || (isSCSI && isSCSISingle)}', + }, + }, ); advancedColumn1.push( @@ -263,15 +273,6 @@ Ext.define('PVE.qemu.HDInputPanel', { disabled: '{isVirtIO}', }, }, - { - xtype: 'proxmoxcheckbox', - name: 'iothread', - fieldLabel: 'IO thread', - clearOnDisable: true, - bind: { - disabled: '{!isVirtIO && !isSCSI}', - }, - }, { xtype: 'proxmoxcheckbox', name: 'readOnly', // `ro` in the config, we map in get/set values -- 2.30.2