From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 848DE7033D for ; Mon, 13 Jun 2022 12:30:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 816FE9E48 for ; Mon, 13 Jun 2022 12:30:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C19099E2A for ; Mon, 13 Jun 2022 12:30:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 984EC41DEC for ; Mon, 13 Jun 2022 12:30:03 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 13 Jun 2022 12:29:58 +0200 Message-Id: <20220613102959.36556-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220613102959.36556-1-f.ebner@proxmox.com> References: <20220613102959.36556-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 guest-common 3/4] replication: also consider storages from replication state upon removal X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 10:30:05 -0000 This prevents left-over volume(s) in the following situation: 1. replication with volumes on different storages A and B 2. remove all volumes on storage B from the guest configuration 3. schedule full removal before the next normal replication runs Signed-off-by: Fabian Ebner --- No changes from v1. src/PVE/Replication.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index d84f469..33fcc48 100644 --- a/src/PVE/Replication.pm +++ b/src/PVE/Replication.pm @@ -270,6 +270,7 @@ sub replicate { if ($remove_job eq 'full' && $jobcfg->{target} ne $local_node) { # remove all remote volumes my @store_list = map { (PVE::Storage::parse_volume_id($_))[0] } @$sorted_volids; + push @store_list, @{$state->{storeid_list}}; my %hash = map { $_ => 1 } @store_list; -- 2.30.2