From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7AF57033B for ; Mon, 13 Jun 2022 12:30:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2C649E3D for ; Mon, 13 Jun 2022 12:30:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 55E3A9E0D for ; Mon, 13 Jun 2022 12:30:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C1F543ADB for ; Mon, 13 Jun 2022 12:30:03 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 13 Jun 2022 12:29:56 +0200 Message-Id: <20220613102959.36556-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220613102959.36556-1-f.ebner@proxmox.com> References: <20220613102959.36556-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 guest-common 1/4] replication: prepare: adapt/expand function comment X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 10:30:04 -0000 Commit 8d1cd44 ("partially fix #3111: replication: be less picky when selecting incremental base") changed prepare() to return all local snapshots. Special behavior regarding last_sync is also better mentioned explicitly. Signed-off-by: Fabian Ebner --- New in v2. src/PVE/Replication.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index 31cabec..fcd59bb 100644 --- a/src/PVE/Replication.pm +++ b/src/PVE/Replication.pm @@ -156,8 +156,9 @@ sub remote_finalize_local_job { PVE::Tools::run_command($cmd, outfunc => $logger, errfunc => $logger); } -# finds local replication snapshots from $last_sync -# and removes all replication snapshots with other time stamps +# Finds all local snapshots and removes replication snapshots not matching $last_sync. Use +# last_sync=0 (or undef) to prevent removal (useful if VM was stolen). Use last_sync=1 to remove all +# replication snapshots (limited to job if specified). sub prepare { my ($storecfg, $volids, $jobid, $last_sync, $parent_snapname, $logfunc) = @_; -- 2.30.2