From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 709E47033C
for <pve-devel@lists.proxmox.com>; Mon, 13 Jun 2022 12:30:05 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6B0E19E47
for <pve-devel@lists.proxmox.com>; Mon, 13 Jun 2022 12:30:05 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 932839E1C
for <pve-devel@lists.proxmox.com>; Mon, 13 Jun 2022 12:30:03 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 69AAC43AC9
for <pve-devel@lists.proxmox.com>; Mon, 13 Jun 2022 12:30:03 +0200 (CEST)
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 13 Jun 2022 12:29:53 +0200
Message-Id: <20220613102959.36556-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.050 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pve-devel] [PATCH-SERIES v2 manager/guest-common] replication:
improve removal of stale snapshots/volumes
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2022 10:30:05 -0000
In certain scenarios, see manager 2/2 and guest-common 3/4, replicated
volumes could end up orphaned. This series attempts to fix those, as
well as making removal of stale replication snaphsots a bit more
robust. Also includes some slight documentation improvements regarding
prepare().
v1 can be found here (but there was no discussion):
https://lists.proxmox.com/pipermail/pve-devel/2020-October/045388.html
Changes from v1:
* Adapt to changed behavior of prepare(), so we still only catch
volumes that had replication snapshots belonging to the job.
* Drop simplification that would only rely on replication state
to get storages for full removal.
* Add safe-guard to only remove other replication snaphsots if the
last_sync snapshot is present.
manager:
Fabian Ebner (2):
pvesr: rename last_snapshots to local_snapshots
pvesr: prepare local job: remove stale replicated volumes immediately
PVE/CLI/pvesr.pm | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
guest-common:
Fabian Ebner (4):
replication: prepare: adapt/expand function comment
replication: rename last_snapshots to local_snapshots
replication: also consider storages from replication state upon
removal
replication: prepare: safeguard against removal if expected snapshot
is missing
src/PVE/Replication.pm | 34 ++++++++++++++++++++--------------
1 file changed, 20 insertions(+), 14 deletions(-)
--
2.30.2