From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 895B770324 for ; Mon, 13 Jun 2022 12:13:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78CC09B19 for ; Mon, 13 Jun 2022 12:13:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 118759B10 for ; Mon, 13 Jun 2022 12:13:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DB6FF4303E for ; Mon, 13 Jun 2022 12:13:27 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Mon, 13 Jun 2022 12:13:16 +0200 Message-Id: <20220613101316.499875-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.456 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 manager] fix #3961: pveam: error on 'list' if storage doesn't exist X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 10:13:58 -0000 storage_check_enabled() already dies with an appropriate error message so we don't have to handle it here Signed-off-by: Oguz Bektas --- v1->v2: * use storage_check_enabled() to address fabi's review PVE/CLI/pveam.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/CLI/pveam.pm b/PVE/CLI/pveam.pm index 67a912bd..3db2a3c8 100644 --- a/PVE/CLI/pveam.pm +++ b/PVE/CLI/pveam.pm @@ -122,6 +122,8 @@ __PACKAGE__->register_method ({ my $cfg = PVE::Storage::config(); + PVE::Storage::storage_check_enabled($cfg, $storeid); + die "Storage does not support templates!\n" if !$cfg->{ids}->{$storeid}->{content}->{vztmpl}; my $vollist = PVE::Storage::volume_list($cfg, $storeid, undef, 'vztmpl'); -- 2.30.2