From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 68D0873FD6; Tue, 31 May 2022 13:18:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F42E8069; Tue, 31 May 2022 13:17:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C1536803B; Tue, 31 May 2022 13:17:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 93E69429B2; Tue, 31 May 2022 13:17:27 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Tue, 31 May 2022 13:17:26 +0200 Message-Id: <20220531111726.2972022-8-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220531111726.2972022-1-d.csapak@proxmox.com> References: <20220531111726.2972022-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit 1/1] window/FileBrowser: enable tar button by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 11:18:02 -0000 all endpoints now can handle the 'tar' parameter, so add it for all Signed-off-by: Dominik Csapak --- src/window/FileBrowser.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js index a519d6b..c2f485a 100644 --- a/src/window/FileBrowser.js +++ b/src/window/FileBrowser.js @@ -61,10 +61,6 @@ Ext.define("Proxmox.window.FileBrowser", { 'd': true, // directories }, - // enable tar download, this will add a menu to the "Download" button when the selection - // can be downloaded as `.tar` files - enableTar: false, - // prefix to prepend to downloaded file names downloadPrefix: '', }, @@ -127,7 +123,7 @@ Ext.define("Proxmox.window.FileBrowser", { view.lookup('selectText').setText(st); let canDownload = view.downloadURL && view.downloadableFileTypes[data.type]; - let enableMenu = view.enableTar && data.type === 'd'; + let enableMenu = data.type === 'd'; let downloadBtn = view.lookup('downloadBtn'); downloadBtn.setDisabled(!canDownload || enableMenu); -- 2.30.2