From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B741773F58; Tue, 31 May 2022 13:18:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ADBF9804D; Tue, 31 May 2022 13:17:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 379F98019; Tue, 31 May 2022 13:17:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 05F4D4398A; Tue, 31 May 2022 13:17:27 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Tue, 31 May 2022 13:17:19 +0200 Message-Id: <20220531111726.2972022-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH proxmox/backup/common/storage/wt] add tar.zst download in pve X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 11:18:00 -0000 like we have the tar.zst download button for pbs itself, add it for pve for both vms and container file-restore pve-storage depends on pve-common, which depends on proxmox-backup, which depends on proxmox (we must bump proxmox-compression and add the new version as a dependency; also for the restore-daemon) widget-toolkit could be done differently (just set enableTar to true; either by default or in proxmox-backup), but since we don't use it anywhere else, this seemed wrong also i am not completely happy with the interface: i added a 'tar' parameter to the download path (for gui compatibility) and to the file-restore binary, but moved to a 'format' parameter in the restore-daemon. i'd really prefer to have a single parameter style for that, but i did not want to pass through the 'tar' through all layers, and moving all to a 'format' parameter would be more work (api compatibility etc.). so maybe someone else has another take on, which way i should pursue in a v2? also AFAICS, the restore-daemon and file-restore binary always go together, so do we have to keep the api of the restore-daemon compatible ? (theoretically users could invoke that manually?) proxmox: Dominik Csapak (2): proxmox-compression: make ZstdEncoder stream a bit more generic proxmox-compression: add 'tar_directory' proxmox-compression/Cargo.toml | 1 + proxmox-compression/src/tar.rs | 116 ++++++++++++++++++++++++++++++++ proxmox-compression/src/zstd.rs | 15 +++-- 3 files changed, 127 insertions(+), 5 deletions(-) proxmox-backup: Dominik Csapak (2): restore-daemon: add 'format' parameter to the 'extract' handler file-restore: add 'tar' option to 'extract' command proxmox-file-restore/Cargo.toml | 1 + proxmox-file-restore/src/block_driver.rs | 6 +-- proxmox-file-restore/src/block_driver_qemu.rs | 4 +- proxmox-file-restore/src/main.rs | 51 ++++++++++++++----- .../src/proxmox_restore_daemon/api.rs | 49 +++++++++++++++--- 5 files changed, 88 insertions(+), 23 deletions(-) pve-common: Dominik Csapak (1): PBSClient: add 'tar' parameter to file_restore_extract src/PVE/PBSClient.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) pve-storage: Dominik Csapak (1): api/filerestore: add 'tar' parameter to 'download' api PVE/API2/Storage/FileRestore.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) proxmox-widget-toolkit: Dominik Csapak (1): window/FileBrowser: enable tar button by default src/window/FileBrowser.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.30.2