From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8117A7105D for ; Tue, 17 May 2022 14:20:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 77214288A6 for ; Tue, 17 May 2022 14:20:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0A2752889C for ; Tue, 17 May 2022 14:20:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C86A343674 for ; Tue, 17 May 2022 14:20:25 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 17 May 2022 14:20:22 +0200 Message-Id: <20220517122022.92528-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit] file browser: show "Download" button by default and disable both initially X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 12:20:26 -0000 Previously, the "Download As" button/menu would show initially and clicking it had no effect. In PVE, this was noticeable and confusing. In PBS, the rootdir is already auto-selected when the store loads. Since the button changes automatically with the selection, the issue was not noticeable there. Signed-off-by: Fabian Ebner --- src/window/FileBrowser.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js index a519d6b..8db7c51 100644 --- a/src/window/FileBrowser.js +++ b/src/window/FileBrowser.js @@ -308,12 +308,13 @@ Ext.define("Proxmox.window.FileBrowser", { handler: 'downloadZip', reference: 'downloadBtn', disabled: true, - hidden: true, }, { text: gettext('Download as'), xtype: 'button', reference: 'menuBtn', + disabled: true, + hidden: true, menu: { items: [ { -- 2.30.2