From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9248B71C65 for ; Fri, 13 May 2022 15:56:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89BF92B0B for ; Fri, 13 May 2022 15:56:01 +0200 (CEST) Received: from ella.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B6092AFB for ; Fri, 13 May 2022 15:56:00 +0200 (CEST) Received: by ella.proxmox.com (Postfix, from userid 10042) id C0BA35C4860; Fri, 13 May 2022 15:55:54 +0200 (CEST) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Fri, 13 May 2022 15:55:48 +0200 Message-Id: <20220513135550.1856651-1-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH storage 0/2] cifs plugin - add options parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 13:56:31 -0000 This adds the options parameter to the CIFS plugin. check propertyList is common for all plugins and it is therefore not possible to have options twice with different descriptions. This patch moves the options property from NFSPlugin.pm to the Plugin.pm level. The options parameter has the same use for NFS & CIFS so it shouldn't be confusing that they share it. # pve-storage --- PVE/Storage/CIFSPlugin.pm | 10 ++++++++-- PVE/Storage/NFSPlugin.pm | 4 ---- PVE/Storage/Plugin.pm | 6 ++++++ 3 files changed, 14 insertions(+), 6 deletions(-) # pve-docs --- pve-storage-cifs.adoc | 5 +++++ 1 file changed, 5 insertions(+) -- 2.30.2