From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 13302715D5 for ; Thu, 12 May 2022 11:24:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06F4B24DB8 for ; Thu, 12 May 2022 11:24:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EFEC324DA0 for ; Thu, 12 May 2022 11:24:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C164E43358 for ; Thu, 12 May 2022 11:24:23 +0200 (CEST) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Thu, 12 May 2022 11:24:16 +0200 Message-Id: <20220512092416.137095-4-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220512092416.137095-1-m.heiserer@proxmox.com> References: <20220512092416.137095-1-m.heiserer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.390 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH v3 qemu-server 2/2] Warn in GUI for unlikely iothread config - fixes #3890 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 09:24:55 -0000 Previously, only a plaintext line in the task log showed something was off. Now, the GUI will show it as a warning. Signed-off-by: Matthias Heiserer --- Changes from v2: * locally import PVE::RestEnv log_warn No changes from v1 PVE/QemuServer.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e0fc36e..408133e 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -41,6 +41,7 @@ use PVE::Storage; use PVE::SysFSTools; use PVE::Systemd; use PVE::Tools qw(run_command file_read_firstline file_get_contents dir_glob_foreach get_host_arch $IPV6RE); +use PVE::RESTEnvironment qw(log_warn); use PVE::QMPClient; use PVE::QemuConfig; @@ -3961,7 +3962,9 @@ sub config_to_command { $iothread .= ",iothread=iothread-$controller_prefix$controller"; push @$cmd, '-object', "iothread,id=iothread-$controller_prefix$controller"; } elsif ($drive->{iothread}) { - warn "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n"; + log_warn( + "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n" + ); } my $queues = ''; -- 2.30.2