From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57E127099C for ; Mon, 9 May 2022 09:39:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 50579296B1 for ; Mon, 9 May 2022 09:38:38 +0200 (CEST) Received: from ella.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C3082968C for ; Mon, 9 May 2022 09:38:37 +0200 (CEST) Received: by ella.proxmox.com (Postfix, from userid 10042) id 3390F5C0CBD; Mon, 9 May 2022 09:30:44 +0200 (CEST) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Mon, 9 May 2022 09:30:34 +0200 Message-Id: <20220509073034.822117-4-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220509073034.822117-1-s.hrdlicka@proxmox.com> References: <20220509073034.822117-1-s.hrdlicka@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server 3/3] remove dependency on Term::ReadLine (see #2077) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2022 07:39:08 -0000 depends on change in pve-common Signed-off-by: Stefan Hrdlicka --- This wasn't in the ticket but I found the dependency here as well and removed it. PVE/CLI/qm.pm | 4 ++-- debian/control | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index cf0d6f3..9579967 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -12,7 +12,6 @@ use IO::Select; use IO::Socket::UNIX; use JSON; use POSIX qw(strftime); -use Term::ReadLine; use URI::Escape; use PVE::Cluster; @@ -24,6 +23,7 @@ use PVE::Network; use PVE::RPCEnvironment; use PVE::SafeSyslog; use PVE::Tools qw(extract_param); +use PVE::PTY; use PVE::API2::Qemu::Agent; use PVE::API2::Qemu; @@ -392,7 +392,7 @@ __PACKAGE__->register_method ({ my $term = Term::ReadLine->new('qm'); - while (defined(my $input = $term->readline('qm> '))) { + while (defined(my $input = PVE::PTY::read_input('qm> '))) { chomp $input; next if $input =~ m/^\s*$/; last if $input =~ m/^\s*q(uit)?\s*$/; diff --git a/debian/control b/debian/control index 7de9e84..62869ac 100644 --- a/debian/control +++ b/debian/control @@ -38,7 +38,6 @@ Depends: dbus, libpve-common-perl (>= 7.1-3), libpve-guest-common-perl (>= 4.1-1), libpve-storage-perl (>= 6.3-8), - libterm-readline-gnu-perl, libuuid-perl, libxml-libxml-perl, perl (>= 5.10.0-19), -- 2.30.2