From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4EA2ABFDD for ; Mon, 2 May 2022 16:24:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AF98283E1 for ; Mon, 2 May 2022 16:24:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C1000283D8 for ; Mon, 2 May 2022 16:24:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9168B4298D for ; Mon, 2 May 2022 16:24:27 +0200 (CEST) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Mon, 2 May 2022 16:24:23 +0200 Message-Id: <20220502142423.749183-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 14:24:58 -0000 They are not used anywhere else, so I assume they were left over from an earlier version. Also, sometimes "[object object] flashes in the Target Guest field when opening the reassign window, with this removed it doesn't occur. Signed-off-by: Matthias Heiserer --- www/manager6/window/GuestDiskReassign.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js index 3795475d..f6d08b32 100644 --- a/www/manager6/window/GuestDiskReassign.js +++ b/www/manager6/window/GuestDiskReassign.js @@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', { }, { xtype: 'vmComboSelector', - reference: 'targetVMID', name: 'targetVmid', allowBlank: false, fieldLabel: gettext('Target Guest'), - bind: { - value: '{targetVMID}', - }, store: { model: 'PVEResources', autoLoad: true, -- 2.30.2