From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1904CB54F for ; Fri, 29 Apr 2022 11:29:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16F829447 for ; Fri, 29 Apr 2022 11:29:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 443349434 for ; Fri, 29 Apr 2022 11:29:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C1E64302C for ; Fri, 29 Apr 2022 11:29:00 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 29 Apr 2022 11:28:58 +0200 Message-Id: <20220429092859.1044258-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/2] api: ceph ec pools: schema fixes and enhancements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 09:29:01 -0000 Ceph has a min value for 'k' of 2. Adding default and description where missing. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/Pools.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm index eeb81d65..4e28453c 100644 --- a/PVE/API2/Ceph/Pools.pm +++ b/PVE/API2/Ceph/Pools.pm @@ -321,7 +321,7 @@ my $ec_format = { type => 'integer', description => "Number of data chunks. Will create an erasure coded pool plus a" ." replicated pool for metadata.", - minimum => 1, + minimum => 2, }, m => { type => 'integer', @@ -335,6 +335,7 @@ my $ec_format = { ." coded pool plus a replicated pool for metadata.", format_description => 'domain', optional => 1, + default => 'host', }, 'device-class' => { type => 'string', @@ -386,6 +387,8 @@ __PACKAGE__->register_method ({ optional => 1, }, 'erasure-coding' => { + description => "Create an erasure coded pool for RBD with an ". + "accompaning replicated pool for metadata storage.", type => 'string', format => $ec_format, optional => 1, -- 2.30.2