From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E06199FA5 for ; Wed, 27 Apr 2022 14:33:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DDBF3264B8 for ; Wed, 27 Apr 2022 14:33:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EE494264A3 for ; Wed, 27 Apr 2022 14:33:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA55B42E07 for ; Wed, 27 Apr 2022 14:33:12 +0200 (CEST) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Wed, 27 Apr 2022 14:33:02 +0200 Message-Id: <20220427123304.1041958-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/3] HDEdit: always show io thread checkbox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 12:33:13 -0000 Previously, it was in the advanced section. In the qemu wizard, bind iothread to the SCSI controller, so that the unlikely/impossible combination of anything other than SCSI-single with iothread can't be accidentally selected. However, in the guest options, iothread and SCSI controller can still be changed independantly. Signed-off-by: Matthias Heiserer --- www/manager6/qemu/HDEdit.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index c643ee73..9dea9984 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -251,6 +251,17 @@ Ext.define('PVE.qemu.HDInputPanel', { reference: 'discard', name: 'discard', }, + { + xtype: 'proxmoxcheckbox', + name: 'iothread', + fieldLabel: 'IO thread', + clearOnDisable: true, + bind: { + disabled: '{!isVirtIO && !isSCSI}', + // only for wizard + value: '{current.scsihw === "virtio-scsi-single"}', + }, + }, ); advancedColumn1.push( @@ -263,15 +274,6 @@ Ext.define('PVE.qemu.HDInputPanel', { disabled: '{isVirtIO}', }, }, - { - xtype: 'proxmoxcheckbox', - name: 'iothread', - fieldLabel: 'IO thread', - clearOnDisable: true, - bind: { - disabled: '{!isVirtIO && !isSCSI}', - }, - }, { xtype: 'proxmoxcheckbox', name: 'readOnly', // `ro` in the config, we map in get/set values -- 2.30.2