From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C77F79881 for ; Tue, 26 Apr 2022 14:35:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C02BD1BCA6 for ; Tue, 26 Apr 2022 14:35:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7F62D1BBA6 for ; Tue, 26 Apr 2022 14:35:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5A11C42BA6 for ; Tue, 26 Apr 2022 14:35:50 +0200 (CEST) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Tue, 26 Apr 2022 14:35:42 +0200 Message-Id: <20220426123542.154739-8-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220426123542.154739-1-d.tschlatscher@proxmox.com> References: <20220426123542.154739-1-d.tschlatscher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pmg-gui 1/1] Replaced the system-report file download implementation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 12:35:53 -0000 with the newly added downloadStringAsFile() function in the proxmox- widget-toolkit repository in the Utils class (Proxmox.Utils). Signed-off-by: Daniel Tschlatscher --- js/Subscription.js | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/js/Subscription.js b/js/Subscription.js index 8d3bc80..16c4c82 100644 --- a/js/Subscription.js +++ b/js/Subscription.js @@ -62,19 +62,7 @@ Ext.define('PMG.Subscription', { let fileContent = Ext.String.htmlDecode(reportWindow.getComponent('system-report-view').html); let fileName = getReportFileName(); - // Internet Explorer - if (window.navigator.msSaveOrOpenBlob) { - navigator.msSaveOrOpenBlob(new Blob([fileContent]), fileName); - } else { - let element = document.createElement('a'); - element.setAttribute('href', 'data:text/plain;charset=utf-8,' - + encodeURIComponent(fileContent)); - element.setAttribute('download', fileName); - element.style.display = 'none'; - document.body.appendChild(element); - element.click(); - document.body.removeChild(element); - } + Proxmox.Utils.downloadStringAsFile(fileContent, fileName); }, }, ], -- 2.30.2