From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 18876E21F for ; Thu, 21 Apr 2022 13:27:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5BA4C1E331 for ; Thu, 21 Apr 2022 13:27:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 395161E248 for ; Thu, 21 Apr 2022 13:27:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 13D784268F for ; Thu, 21 Apr 2022 13:27:07 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 21 Apr 2022 13:26:57 +0200 Message-Id: <20220421112659.74011-12-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220421112659.74011-1-f.ebner@proxmox.com> References: <20220421112659.74011-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager 1/3] ui: restore: disallow empty storage selection if it wouldn't work X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 11:27:42 -0000 Namely, if there is a storage in the backup configuration that's not available on the current node. Signed-off-by: Fabian Ebner --- New in v2. www/manager6/window/Restore.js | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index e7b3e945..25babf89 100644 --- a/www/manager6/window/Restore.js +++ b/www/manager6/window/Restore.js @@ -15,6 +15,40 @@ Ext.define('PVE.window.Restore', { }, }, }, + + afterRender: function() { + let view = this.getView(); + + Proxmox.Utils.API2Request({ + url: `/nodes/${view.nodename}/vzdump/extractconfig`, + method: 'GET', + params: { + volume: view.volid, + }, + failure: (response) => Ext.Msg.alert('Error', response.htmlStatus), + success: function(response, options) { + let storagesAvailable = true; + + response.result.data.split('\n').forEach(function(line) { + let match = line.match( + /^#qmdump#map:(\S+):(\S+):(\S*):(\S*):$/, + ); + if (match) { + let currentAvailable = !!PVE.data.ResourceStore.getById( + `storage/${view.nodename}/${match[3]}`, + ); + storagesAvailable = storagesAvailable && currentAvailable; + } + }); + + if (!storagesAvailable) { + let storagesel = view.down('pveStorageSelector[name=storage]'); + storagesel.allowBlank = false; + storagesel.setEmptyText(''); + } + }, + }); + }, }, initComponent: function() { -- 2.30.2