From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3C532CAC5 for ; Tue, 12 Apr 2022 15:34:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AB6510202 for ; Tue, 12 Apr 2022 15:34:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 76DF2100D4 for ; Tue, 12 Apr 2022 15:34:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4ABB7416AD for ; Tue, 12 Apr 2022 15:34:24 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 12 Apr 2022 15:34:10 +0200 Message-Id: <20220412133423.1021857-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220412133423.1021857-1-d.csapak@proxmox.com> References: <20220412133423.1021857-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.138 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cluster.pm] Subject: [pve-devel] [PATCH cluster v6 2/3] Cluster: add get_guest_config_properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 13:34:26 -0000 akin to get_guest_config_property, but with a list of properties. uses the new CFS_IPC_GET_GUEST_CONFIG_PROPERTIES also adds the same NOTEs regarding parsing/permissions to the comment of get_guest_config_property Signed-off-by: Dominik Csapak --- data/PVE/Cluster.pm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 05451fd..d0148fc 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -340,10 +340,37 @@ sub get_node_kv { return $res; } +# properties: an array-ref of config properties you want to get, e.g., this +# is perfect to get multiple properties of a guest _fast_ +# (>100 faster than manual parsing here) +# vmid: optional, if a valid is passed we only check that one, else return all +# NOTE: does *not* searches snapshot and PENDING entries sections! +# NOTE: returns the guest config lines (excluding trailing whitespace) as is, +# so for non-trivial properties, checking the validity must be done +# NOTE: no permission check is done, that is the responsibilty of the caller +sub get_guest_config_properties { + my ($properties, $vmid) = @_; + + die "properties required" if !defined($properties); + + my $num_props = scalar(@$properties); + die "only up to 255 properties supported" if $num_props > 255; + my $bindata = pack "VC", $vmid // 0, $num_props; + for my $property (@$properties) { + $bindata .= pack "Z*", $property; + } + my $res = $ipcc_send_rec_json->(CFS_IPC_GET_GUEST_CONFIG_PROPERTIES, $bindata); + + return $res; +} + # property: a config property you want to get, e.g., this is perfect to get # the 'lock' entry of a guest _fast_ (>100 faster than manual parsing here) # vmid: optional, if a valid is passed we only check that one, else return all # NOTE: does *not* searches snapshot and PENDING entries sections! +# NOTE: returns the guest config lines (excluding trailing whitespace) as is, +# so for non-trivial properties, checking the validity must be done +# NOTE: no permission check is done, that is the responsibilty of the caller sub get_guest_config_property { my ($property, $vmid) = @_; -- 2.30.2