From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A28EBB93C for ; Thu, 7 Apr 2022 14:15:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9903A4A31 for ; Thu, 7 Apr 2022 14:15:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 87E014A22 for ; Thu, 7 Apr 2022 14:15:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5D447459DA for ; Thu, 7 Apr 2022 14:15:48 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 7 Apr 2022 14:15:44 +0200 Message-Id: <20220407121544.159514-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.105 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: lxc: resources: consider rootfs as a disk again X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 12:15:49 -0000 Commit fa7980c2 ("ui: lxc resources: switch to vector based font awesome icons") seems like an innocent change, but it broke the (very brittle) logic here by removing the tdCls for rootfs. Signed-off-by: Fabian Ebner --- www/manager6/lxc/Resources.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js index 683be526..7db55280 100644 --- a/www/manager6/lxc/Resources.js +++ b/www/manager6/lxc/Resources.js @@ -263,7 +263,7 @@ Ext.define('PVE.lxc.RessourceView', { var rowdef = rows[key]; var pending = rec.data.delete || me.hasPendingChanges(key); - var isDisk = rowdef.tdCls === 'pve-itype-icon-storage'; + let isDisk = key === 'rootfs' || key.match(/^(mp|unused)\d+/); var isUnusedDisk = key.match(/^unused\d+/); var isUsedDisk = isDisk && !isUnusedDisk; -- 2.30.2