From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 95BF6B77C for ; Thu, 7 Apr 2022 12:06:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD3F5353F for ; Thu, 7 Apr 2022 12:05:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9921D34DB for ; Thu, 7 Apr 2022 12:05:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 72D8C459DA for ; Thu, 7 Apr 2022 12:05:47 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 7 Apr 2022 12:05:43 +0200 Message-Id: <20220407100543.130953-7-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220407100543.130953-1-f.ebner@proxmox.com> References: <20220407100543.130953-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.107 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager 4/4] close #438: ui: backup job: allow setting a notes-template for a job X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 10:06:20 -0000 Add a tooltip to the comment field, to better distinguish it from the notes-template. Signed-off-by: Fabian Ebner --- Changes from v2: * Squash in patch setting default value. * Switch to {{var}} syntax. * Use singular "backup" in gettext to be able to reuse same message as for manual backup. www/manager6/dc/Backup.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 2b892c6f..9b129266 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -231,6 +231,24 @@ Ext.define('PVE.dc.BackupEdit', { name: 'comment', fieldLabel: gettext('Comment'), deleteEmpty: !me.isCreate, + autoEl: { + tag: 'div', + 'data-qtip': gettext('Description of the job'), + }, + }, + { + xtype: 'proxmoxtextfield', + name: 'notes-template', + fieldLabel: gettext('Notes'), + deleteEmpty: !me.isCreate, + value: me.isCreate ? '{{guestname}}' : undefined, + autoEl: { + tag: 'div', + 'data-qtip': Ext.String.format( + gettext('Notes added to the backup. Possible variables are {0}'), + '{{cluster}}, {{guestname}}, {{node}}, {{vmid}}', + ), + }, }, ], onGetValues: function(values) { -- 2.30.2