From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 22956B805 for ; Thu, 7 Apr 2022 12:06:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B072635BF for ; Thu, 7 Apr 2022 12:05:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B381D34E0 for ; Thu, 7 Apr 2022 12:05:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8CEB546158 for ; Thu, 7 Apr 2022 12:05:47 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 7 Apr 2022 12:05:42 +0200 Message-Id: <20220407100543.130953-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220407100543.130953-1-f.ebner@proxmox.com> References: <20220407100543.130953-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.107 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager 3/4] ui: backup: allow setting protected and notes-template for manual backup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 10:06:21 -0000 Setting a width, so the text area can fill the horizontal space. Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- Changes from v2: * Add default value and tooltip for notes-tempalte. www/manager6/window/Backup.js | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 726122c8..c4aafec1 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -154,19 +154,41 @@ Ext.define('PVE.window.Backup', { }, }); + let protectedCheckbox = Ext.create('Proxmox.form.Checkbox', { + name: 'protected', + checked: false, + uncheckedValue: 0, + fieldLabel: gettext('Protected'), + }); + me.formPanel = Ext.create('Proxmox.panel.InputPanel', { bodyPadding: 10, border: false, column1: [ storagesel, modeSelector, - removeCheckbox, + protectedCheckbox, ], column2: [ compressionSelector, mailtoField, + removeCheckbox, ], columnB: [ + { + xtype: 'textareafield', + name: 'notes-template', + fieldLabel: gettext('Notes'), + anchor: '100%', + value: '{{guestname}}', + autoEl: { + tag: 'div', + 'data-qtip': Ext.String.format( + gettext('Notes added to the backup. Possible variables are {0}'), + '{{cluster}}, {{guestname}}, {{node}}, {{vmid}}', + ), + }, + }, { xtype: 'label', name: 'pruneLabel', @@ -229,6 +251,14 @@ Ext.define('PVE.window.Backup', { params.compress = values.compress; } + if (values.protected) { + params.protected = values.protected; + } + + if (values['notes-template']) { + params['notes-template'] = values['notes-template']; + } + Proxmox.Utils.API2Request({ url: '/nodes/' + me.nodename + '/vzdump', params: params, @@ -272,6 +302,7 @@ Ext.define('PVE.window.Backup', { modal: true, layout: 'auto', border: false, + width: 600, items: [me.formPanel], buttons: [helpBtn, '->', submitBtn], listeners: { -- 2.30.2